Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: bug-hurd@gnu.org, thomas@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: [PATCH,Hurd] Fix deallocation after proc_getprocinfo call
Date: Sun, 23 Nov 2014 09:13:00 -0000	[thread overview]
Message-ID: <20141123091347.GV4576@type.youpi.perso.aquilenet.fr> (raw)
In-Reply-To: <20141123074452.GC7136@adacore.com>

Joel Brobecker, le Sun 23 Nov 2014 11:44:52 +0400, a écrit :
> > -      vm_deallocate (mach_task_self (), (vm_address_t) pi, pi_len);
> > +      vm_deallocate (mach_task_self (), (vm_address_t) pi, pi_len * sizeof (*(procinfo_t) 0));
> 
> Suggest using "sizeof (struct procinfo)", which I think is better
> than dereferencing a NULL pointer. This is based on guessing that
> type procinfo_t is a pointer to struct procinfo, as suggested by
> the code in inf_validate_procinfo.

Not, that is not the same: struct procinfo has an open array at its end
(threadinfos[0]), and thus the actually allocated size is variable.

Samuel


  reply	other threads:[~2014-11-23  9:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-02 15:26 Samuel Thibault
2014-11-23  7:44 ` Joel Brobecker
2014-11-23  9:13   ` Samuel Thibault [this message]
2014-11-23  9:56     ` Joel Brobecker
2014-11-23 15:21       ` Samuel Thibault
2014-11-23 15:19   ` [PATCHv2,Hurd] " Samuel Thibault
2014-11-24  9:28     ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141123091347.GV4576@type.youpi.perso.aquilenet.fr \
    --to=samuel.thibault@gnu.org \
    --cc=brobecker@adacore.com \
    --cc=bug-hurd@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=thomas@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox