From: Joel Brobecker <brobecker@adacore.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Doug Evans <xdje42@gmail.com>,
gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add gdbarch_sizeof_g_packet to "struct remote_arch_state" to handle the issue that get error "Remote 'g' packet reply is too long" with qemu-system-x86_64
Date: Mon, 17 Nov 2014 10:25:00 -0000 [thread overview]
Message-ID: <20141117102518.GL5774@adacore.com> (raw)
In-Reply-To: <CANFwon2mnb85tdGJHU=QNaHrHDi0Qv_GGM0ZHD4_G4DBOxe2Og@mail.gmail.com>
> Will GDB be hurted if it support bigger size? Maybe GDB can output a
> warning like "the size that you use is bigger than xxxxxx", And keep
> work.
> But not just tell the user "your target is cheater. It changed the
> size. I hate that. I will not work with it."
> GDB is a debugger but not a judge, right?
Yes, GDB will be hurt if we try applying bandaids for issues
we don't understand. One bandaid doesn't seem like much, but
they accumulate over time, and make long-term maintenance
a lot harder.
We need to understand what is going on before we can determine
whether the fix you are proposing is the best approach.
--
Joel
prev parent reply other threads:[~2014-11-17 10:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 15:11 Hui Zhu
2014-09-02 3:26 ` Hui Zhu
2014-11-17 7:09 ` Hui Zhu
2014-11-17 7:23 ` Doug Evans
2014-11-17 8:12 ` Hui Zhu
2014-11-17 10:25 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141117102518.GL5774@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox