From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6880 invoked by alias); 16 Nov 2014 11:09:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6867 invoked by uid 89); 16 Nov 2014 11:09:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sun, 16 Nov 2014 11:09:38 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 599381165BD; Sun, 16 Nov 2014 06:09:36 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id NwltehA9HHy8; Sun, 16 Nov 2014 06:09:36 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id F23DE1165B3; Sun, 16 Nov 2014 06:09:34 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 4DF5940F79; Sun, 16 Nov 2014 15:09:34 +0400 (RET) Date: Sun, 16 Nov 2014 11:09:00 -0000 From: Joel Brobecker To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, Rich Fuhler , Richard Sandiford Subject: Re: [PATCH v2 2/2] Correct invalid assumptions made by (mostly) DWARF-2 tests Message-ID: <20141116110934.GH5774@adacore.com> References: <20120611182043.GA7597@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-11/txt/msg00377.txt.bz2 > 2014-10-06 Maciej W. Rozycki > > gdb/testsuite/ > * gdb.cp/expand-psymtabs-cxx.exp: Accept any address of > `method(long)', not just 0x0. > * gdb.cp/nsalias.exp: Align code labels to 4. > * gdb.dwarf2/dw2-canonicalize-type.S (main): Expand to 4-bytes. > * gdb.dwarf2/dw2-empty-pc-range.S (main): Likewise. > * gdb.dwarf2/pr11465.S (_ZN1N1cE): Likewise. > * gdb.dwarf2/dw2-case-insensitive.c (START_INSNS): New macro. > (cu_text_start, FUNC_lang_start): Use `START_INSNS'. > * gdb.dwarf2/dw2-stack-boundary.exp: Accept noise in complaints. Overall, everything looks very reasonable. Small nit: There is a space at the end of the first CL line (after "address of"). One question (pre-approved if my suggestion works): > Index: gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/dw2-canonicalize-type.S > =================================================================== > --- gdb-fsf-trunk-quilt.orig/gdb/testsuite/gdb.dwarf2/dw2-canonicalize-type.S 2014-10-02 07:56:23.000000000 +0100 > +++ gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/dw2-canonicalize-type.S 2014-10-02 07:58:10.978958268 +0100 > @@ -15,7 +15,8 @@ > > .text > .globl main > -main: .byte 0 > +main: > + .dc.l 0 We've never used .dl.l before, and I don't know how widely available it is (in fact, I couldn't find it in the GAS manual). How about using .word or .4byte? It would also be consistent with what we've usually be using. Would that work? > Index: gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/dw2-empty-pc-range.S > =================================================================== > --- gdb-fsf-trunk-quilt.orig/gdb/testsuite/gdb.dwarf2/dw2-empty-pc-range.S 2014-10-02 07:56:23.000000000 +0100 > +++ gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/dw2-empty-pc-range.S 2014-10-02 07:58:10.978958268 +0100 > @@ -15,7 +15,7 @@ > > .text > pc_start: > - .byte 0 > + .dc.l 0 > pc_end: Same here... > Index: gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/pr11465.S > =================================================================== > --- gdb-fsf-trunk-quilt.orig/gdb/testsuite/gdb.dwarf2/pr11465.S 2014-10-02 07:56:23.000000000 +0100 > +++ gdb-fsf-trunk-quilt/gdb/testsuite/gdb.dwarf2/pr11465.S 2014-10-02 07:58:10.978958268 +0100 > @@ -39,7 +39,7 @@ > text_start: > _ZN1N1cE: > /* Valid function must have non-empty PC range. */ > - .byte 0 > + .dc.l 0 ... and here. -- Joel