From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23867 invoked by alias); 16 Nov 2014 03:22:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23852 invoked by uid 89); 16 Nov 2014 03:22:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sun, 16 Nov 2014 03:22:17 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 301251165A3; Sat, 15 Nov 2014 22:22:15 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id QGs7hu7VLbu8; Sat, 15 Nov 2014 22:22:15 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C91591165A0; Sat, 15 Nov 2014 22:22:14 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 36DB740F79; Sun, 16 Nov 2014 07:22:13 +0400 (RET) Date: Sun, 16 Nov 2014 03:22:00 -0000 From: Joel Brobecker To: Doug Evans Cc: Yao Qi , "gdb-patches@sourceware.org" Subject: Re: [PATCH 7/9] Rewrite lookup_static_symbol to use gdbarch routine Message-ID: <20141116032213.GF5774@adacore.com> References: <87d29cvqfu.fsf@codesourcery.com> <87y4rfjm9h.fsf@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-11/txt/msg00370.txt.bz2 Hi Doug, > To keep things moving along I added the copyright headers. Thanks for doing that. > However, I think we could be a bit more lax when it comes to > such trivial testcases. The FSF allows us to be lax for trivial files (with 10 lines being one explicit limit on triviality). But: The problem with being lax is that it creates a little extra work for us at the start of each year, when we update the copyright headers. The FSF has been asking us to look into copyright headers in the past, and it was a lot of work, so I've added a bit of simple-minded code to the script that updates the copyright headers in GDB to also issue a warning if a copyright header hasn't been found. That way, we can then investigate the few problematic files each year rather than a massive number when the FSF notices something. That's why I always appreciate the copyright headers being added right from the start. So, again, thanks a lot for adding those! :) -- Joel