From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28646 invoked by alias); 5 Nov 2014 11:00:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28619 invoked by uid 89); 5 Nov 2014 11:00:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: cam-smtp0.cambridge.arm.com Received: from fw-tnat.cambridge.arm.com (HELO cam-smtp0.cambridge.arm.com) (217.140.96.21) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 05 Nov 2014 11:00:38 +0000 Received: from arm.com (e106375-lin.cambridge.arm.com [10.1.203.34]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id sA5B0Q7N012202; Wed, 5 Nov 2014 11:00:26 GMT Date: Wed, 05 Nov 2014 11:00:00 -0000 From: James Greenhalgh To: Alan Modra Cc: Siva Chandra , Ulrich Weigand , gdb-patches Subject: Re: [PATCH] PR c++/17494 - Fix evaluation of method calls under EVAL_SKIP Message-ID: <20141105110026.GA31231@arm.com> References: <201411031508.sA3F815b024788@d06av02.portsmouth.uk.ibm.com> <20141105002415.GG20070@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20141105002415.GG20070@bubble.grove.modra.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00099.txt.bz2 On Wed, Nov 05, 2014 at 12:24:16AM +0000, Alan Modra wrote: > On Mon, Nov 03, 2014 at 06:08:15PM -0800, Siva Chandra wrote: > > >> PR c++/17494 > > >> * eval.c (evaluate_subexp_standard): Evaluate the "object" and > > >> the method args also under EVAL_SKIP when evaluating method > > >> calls under EVAL_SKIP. > > > > Thanks for the review. Pushed: e0f52461c2467b6610391681fa27cd9b3c5def57 > > After this patch, when using gcc-4.9.1 and gcc-5.0 (20140911) I see > what looks to me to be nonsense errors (ie. I'd suspect a compiler > bug). Does anyone else see the same? Nothing special in configure > options, x86_64-linux. For what it is worth, I'm seeing the same with my GCC 4.9.1 (x84_64-linux), again nothing special in the configure options for GCC: ../gcc-4.9.1/configure --enable-checking=release --with-cpu=native Thanks, James > /src/binutils-gdb/gdb/eval.c: In function ‘evaluate_subexp_standard’: > /src/binutils-gdb/gdb/eval.c:745:16: error: ‘ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > struct value *ret = NULL; > ^ > In file included from /src/binutils-gdb/gdb/common/common-defs.h:49:0, > from /src/binutils-gdb/gdb/defs.h:28, > from /src/binutils-gdb/gdb/eval.c:20: > /src/binutils-gdb/gdb/common/common-exceptions.h:148:20: error: ‘buf’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > SIGJMP_BUF *buf = \ > ^ > /src/binutils-gdb/gdb/common/common-exceptions.h:148:20: note: ‘buf’ was declared here > SIGJMP_BUF *buf = \ > ^ > /src/binutils-gdb/gdb/eval.c:747:2: note: in expansion of macro ‘TRY_CATCH’ > TRY_CATCH (ex, RETURN_MASK_ERROR) > ^ > /src/binutils-gdb/gdb/eval.c:1429:19: error: ‘value’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > struct value *value = NULL; > ^ > In file included from /src/binutils-gdb/gdb/common/common-defs.h:49:0, > from /src/binutils-gdb/gdb/defs.h:28, > from /src/binutils-gdb/gdb/eval.c:20: > /src/binutils-gdb/gdb/common/common-exceptions.h:148:20: error: ‘buf’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > SIGJMP_BUF *buf = \ > ^ > /src/binutils-gdb/gdb/common/common-exceptions.h:148:20: note: ‘buf’ was declared here > SIGJMP_BUF *buf = \ > ^ > /src/binutils-gdb/gdb/eval.c:1430:5: note: in expansion of macro ‘TRY_CATCH’ > TRY_CATCH (except, RETURN_MASK_ERROR) > ^ > /src/binutils-gdb/gdb/eval.c:1846:18: error: ‘value’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > struct value *value = NULL; > ^ > In file included from /src/binutils-gdb/gdb/common/common-defs.h:49:0, > from /src/binutils-gdb/gdb/defs.h:28, > from /src/binutils-gdb/gdb/eval.c:20: > /src/binutils-gdb/gdb/common/common-exceptions.h:148:20: error: ‘buf’ may be used uninitialized in this function [-Werror=maybe-uninitialized] > SIGJMP_BUF *buf = \ > ^ > /src/binutils-gdb/gdb/common/common-exceptions.h:148:20: note: ‘buf’ was declared here > SIGJMP_BUF *buf = \ > ^ > /src/binutils-gdb/gdb/eval.c:1847:4: note: in expansion of macro ‘TRY_CATCH’ > TRY_CATCH (except, RETURN_MASK_ERROR) > ^ > cc1: all warnings being treated as errors > > > -- > Alan Modra > Australia Development Lab, IBM >