From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14896 invoked by alias); 5 Nov 2014 00:24:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14885 invoked by uid 89); 5 Nov 2014 00:24:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f46.google.com Received: from mail-pa0-f46.google.com (HELO mail-pa0-f46.google.com) (209.85.220.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 05 Nov 2014 00:24:26 +0000 Received: by mail-pa0-f46.google.com with SMTP id lf10so15543342pab.33 for ; Tue, 04 Nov 2014 16:24:24 -0800 (PST) X-Received: by 10.70.9.33 with SMTP id w1mr9539466pda.150.1415147064224; Tue, 04 Nov 2014 16:24:24 -0800 (PST) Received: from bubble.grove.modra.org (CPE-58-160-155-134.oycza5.sa.bigpond.net.au. [58.160.155.134]) by mx.google.com with ESMTPSA id a13sm1378594pbu.77.2014.11.04.16.24.22 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Nov 2014 16:24:23 -0800 (PST) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 2CBACEA5E3D; Wed, 5 Nov 2014 10:54:16 +1030 (ACDT) Date: Wed, 05 Nov 2014 00:24:00 -0000 From: Alan Modra To: Siva Chandra Cc: Ulrich Weigand , gdb-patches Subject: Re: [PATCH] PR c++/17494 - Fix evaluation of method calls under EVAL_SKIP Message-ID: <20141105002415.GG20070@bubble.grove.modra.org> References: <201411031508.sA3F815b024788@d06av02.portsmouth.uk.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2014-11/txt/msg00090.txt.bz2 On Mon, Nov 03, 2014 at 06:08:15PM -0800, Siva Chandra wrote: > >> PR c++/17494 > >> * eval.c (evaluate_subexp_standard): Evaluate the "object" and > >> the method args also under EVAL_SKIP when evaluating method > >> calls under EVAL_SKIP. > > Thanks for the review. Pushed: e0f52461c2467b6610391681fa27cd9b3c5def57 After this patch, when using gcc-4.9.1 and gcc-5.0 (20140911) I see what looks to me to be nonsense errors (ie. I'd suspect a compiler bug). Does anyone else see the same? Nothing special in configure options, x86_64-linux. /src/binutils-gdb/gdb/eval.c: In function ‘evaluate_subexp_standard’: /src/binutils-gdb/gdb/eval.c:745:16: error: ‘ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized] struct value *ret = NULL; ^ In file included from /src/binutils-gdb/gdb/common/common-defs.h:49:0, from /src/binutils-gdb/gdb/defs.h:28, from /src/binutils-gdb/gdb/eval.c:20: /src/binutils-gdb/gdb/common/common-exceptions.h:148:20: error: ‘buf’ may be used uninitialized in this function [-Werror=maybe-uninitialized] SIGJMP_BUF *buf = \ ^ /src/binutils-gdb/gdb/common/common-exceptions.h:148:20: note: ‘buf’ was declared here SIGJMP_BUF *buf = \ ^ /src/binutils-gdb/gdb/eval.c:747:2: note: in expansion of macro ‘TRY_CATCH’ TRY_CATCH (ex, RETURN_MASK_ERROR) ^ /src/binutils-gdb/gdb/eval.c:1429:19: error: ‘value’ may be used uninitialized in this function [-Werror=maybe-uninitialized] struct value *value = NULL; ^ In file included from /src/binutils-gdb/gdb/common/common-defs.h:49:0, from /src/binutils-gdb/gdb/defs.h:28, from /src/binutils-gdb/gdb/eval.c:20: /src/binutils-gdb/gdb/common/common-exceptions.h:148:20: error: ‘buf’ may be used uninitialized in this function [-Werror=maybe-uninitialized] SIGJMP_BUF *buf = \ ^ /src/binutils-gdb/gdb/common/common-exceptions.h:148:20: note: ‘buf’ was declared here SIGJMP_BUF *buf = \ ^ /src/binutils-gdb/gdb/eval.c:1430:5: note: in expansion of macro ‘TRY_CATCH’ TRY_CATCH (except, RETURN_MASK_ERROR) ^ /src/binutils-gdb/gdb/eval.c:1846:18: error: ‘value’ may be used uninitialized in this function [-Werror=maybe-uninitialized] struct value *value = NULL; ^ In file included from /src/binutils-gdb/gdb/common/common-defs.h:49:0, from /src/binutils-gdb/gdb/defs.h:28, from /src/binutils-gdb/gdb/eval.c:20: /src/binutils-gdb/gdb/common/common-exceptions.h:148:20: error: ‘buf’ may be used uninitialized in this function [-Werror=maybe-uninitialized] SIGJMP_BUF *buf = \ ^ /src/binutils-gdb/gdb/common/common-exceptions.h:148:20: note: ‘buf’ was declared here SIGJMP_BUF *buf = \ ^ /src/binutils-gdb/gdb/eval.c:1847:4: note: in expansion of macro ‘TRY_CATCH’ TRY_CATCH (except, RETURN_MASK_ERROR) ^ cc1: all warnings being treated as errors -- Alan Modra Australia Development Lab, IBM