Re: [PATCH v4] Make chained function calls in expressions work

Ulrich Weigand
2014-11-04T15:40:57Z

Siva Chandra wrote:
> On Tue, Nov 4, 2014 at 6:58 AM, Ulrich Weigand <uweigand@de.ibm.com> wrote:
> > Siva Chandra wrote:
> >> On Tue, Nov 4, 2014 at 5:38 AM, Ulrich Weigand <uweigand@de.ibm.com> wrote:
> >> > Yes, having an additional flag in struct expression would fix the safety
> >> > issue. Moving initialization to evalute_subexp if *pos == 0 would then
> >> > no longer be safety issue, but simply enabling use of temporaries in more
> >> > cases.
> >>
> >> Since I have my code already setup in this fashion, I would prefer to
> >> go this route unless you see an advantage of going with the solution
> >> you suggest below.
> >
> > Well, I don't think there are any functional advantages as such, but the
> > implementation looks a bit cleaner (all the details of temporary handling
> > done in infcall.c; fewer interactions between eval.c and infcall.c;
> > shorter patch overall).
>
> Shall I go with the thread route then?

Yes, please. Sorry for asking for extra work, but I think overall this
will be the better implementation.

Thanks,
Ulrich

--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com