From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6470 invoked by alias); 25 Oct 2014 17:28:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6460 invoked by uid 89); 25 Oct 2014 17:28:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: glazunov.sibelius.xs4all.nl Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 25 Oct 2014 17:28:51 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id s9PHShK8015733; Sat, 25 Oct 2014 19:28:43 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id s9PHSg6v018247; Sat, 25 Oct 2014 19:28:42 +0200 (CEST) Date: Sat, 25 Oct 2014 17:28:00 -0000 Message-Id: <201410251728.s9PHSg6v018247@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: sandra@codesourcery.com CC: gdb-patches@sourceware.org In-reply-to: <544BD7E6.1050602@codesourcery.com> (message from Sandra Loosemore on Sat, 25 Oct 2014 11:03:34 -0600) Subject: Re: GCC switch to C11 causes many testsuite compiler diagnostics References: <544BD7E6.1050602@codesourcery.com> X-SW-Source: 2014-10/txt/msg00699.txt.bz2 > Date: Sat, 25 Oct 2014 11:03:34 -0600 > From: Sandra Loosemore > > Comparing my latest nios2 test results (with Pedro's thread patch) with > those from a checkout a couple weeks old, I noticed I had some new > ERRORs due to apparent compilation failures. I tracked this down to the > recent change on GCC mainline (r216247) to make the default C dialect > GNU11, which enables -Wimplicit-int and -Wimplicit-function-declaration > by default. I started working on a patch to fix the offending > testcases, but realized that there are hundreds of them. :-( > > So, before I invest a lot more time on this, is updating the GDB > testsuite to use a more modern C dialect the Right Thing To Do? I'm > also wondering if it's really necessary to support compilers that can't > handle function prototypes in the testsuite (not defining PROTOTYPES > seems to be the default, in fact). We've quite deliberately kept around a variety of C dialects and coding styles to make sure GDB works with whatever style people use. Having the majority of the tests use K&R style function declarations is probably not so useful anymore. But there are some tests that deliberately use K&_R style code to test whether GDB handles them properly. So blind conversion is probably not a good idea.