From: Joel Brobecker <brobecker@adacore.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>,
gdb-patches@sourceware.org, palves@redhat.com
Subject: Re: [PATCH v2] gdb/i387-tdep.c: Avoid warning for "-Werror=strict-overflow"
Date: Wed, 15 Oct 2014 18:47:00 -0000 [thread overview]
Message-ID: <20141015184711.GF25846@adacore.com> (raw)
In-Reply-To: <543BF857.9080805@gmail.com>
Hi Mark,
> > Sorry, I disagree with this approach. I think your compiler is really
> > being unhelpful here. See if a newer GCC version of the compiler
> > still triggers that warning. If so, complain to the GCC people.
Would you be OK with Pedro's suggested approach where we have
an additional macro that provides the number of ST registers?
That should get rid of the warning, and it seems like the code
might actually even be slightly better for it; it would make it
obvious that you iterate over a fixed number of registers, and
which ones you are interating over; [ST0 .. XMM0[ does not make
it as clear that the range only refers to ST registers, for instance.
--
Joel
next prev parent reply other threads:[~2014-10-15 18:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 13:22 Chen Gang
2014-10-12 14:13 ` Iain Buclaw
2014-10-12 14:41 ` Chen Gang
2014-10-12 17:48 ` Iain Buclaw
2014-10-13 15:16 ` Mark Kettenis
2014-10-13 15:59 ` Chen Gang
2014-10-14 21:31 ` Chen Gang
2014-10-15 18:47 ` Joel Brobecker [this message]
2014-10-15 18:59 ` Mark Kettenis
2014-10-12 23:48 Chen Gang
2014-11-10 1:39 ` Chen Gang
2015-01-09 21:50 ` Chen Gang S
2014-10-16 0:03 Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015184711.GF25846@adacore.com \
--to=brobecker@adacore.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox