From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25959 invoked by alias); 15 Oct 2014 14:35:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25946 invoked by uid 89); 15 Oct 2014 14:35:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 15 Oct 2014 14:35:05 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B750A1161D6; Wed, 15 Oct 2014 10:35:03 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HfMj1lvlmlqc; Wed, 15 Oct 2014 10:35:03 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 90111116157; Wed, 15 Oct 2014 10:35:03 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 2D10440DC3; Wed, 15 Oct 2014 07:35:01 -0700 (PDT) Date: Wed, 15 Oct 2014 14:35:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: RFC: gdbserver crash on win XP during watchpoint removal Message-ID: <20141015143501.GC25846@adacore.com> References: <20141014184647.GB8879@adacore.com> <543D782F.10506@redhat.com> <20141014213727.GA25846@adacore.com> <543DC1FF.8030109@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <543DC1FF.8030109@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-10/txt/msg00397.txt.bz2 > > It looks like just removing the statement that sets dr_control_mirror > > from the thread's DR7 is sufficient to allow hardware watchpoints > > to work again. > > Yes, that sounds good enough for 7.8.1. This is OK. Thanks, Pedro. I created PR server/17487 for this, and pushed the patch on gdb-7.8-branch using that PR. > > I admit I could have spent a little more time trying to understand > > the bigger picture, but I'm a bit under time pressure, so I'm hoping > > this is enough. Otherwise, I'll look at a better fix. > > Hmm, I've wanted to do this for a while. So... Below's is what I > think is the better fix. Thanks! I tested your patch on x86-windows using AdaCore's testsuite, and it also fixes the problem, with no regression. Do you want to push it? I left the PR open pending your patch going in... -- Joel