From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15461 invoked by alias); 14 Oct 2014 13:58:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15443 invoked by uid 89); 14 Oct 2014 13:58:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 14 Oct 2014 13:58:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id EB4E6116277; Tue, 14 Oct 2014 09:58:25 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id PAw-7FLY0SYR; Tue, 14 Oct 2014 09:58:25 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3BC99116259; Tue, 14 Oct 2014 09:58:24 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 4CA9F40E17; Tue, 14 Oct 2014 06:58:24 -0700 (PDT) Date: Tue, 14 Oct 2014 13:58:00 -0000 From: Joel Brobecker To: Iain Buclaw Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Sync libiberty with gcc Message-ID: <20141014135824.GA8879@adacore.com> References: <20141014133804.GA9440@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141014133804.GA9440@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-10/txt/msg00348.txt.bz2 > Unfortunately, this part of the change breaks the build on Solaris 2.9. > And according to the gnulib documentation that function, it looks like > it'll break the build on the following hosts: > > NetBSD 3.0, OpenBSD 3.8, Minix 3.1.8, IRIX 6.5, OSF/1 4.0, > Solaris 9, Cygwin, MSVC 9, Interix 3.5, BeOS. > > Not knowing D and whether you actually need long-double precision > or not, I didn't try to fix it. But it looks like the best option > would probably to add an strtold configure check, and then fallback > on strtod if strtold isn't available (and error out if strtod isn't)? Just a quick note to say that I am working on a patch that I'll apply internally, so I might as well send it to gcc-patches as well. If it is actually the best way to fix this, then it'll save you the trouble. -- Joel