From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18701 invoked by alias); 9 Oct 2014 09:45:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18690 invoked by uid 89); 9 Oct 2014 09:45:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 09 Oct 2014 09:45:35 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s999jXa4010463 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 9 Oct 2014 05:45:33 -0400 Received: from blade.nx (ovpn-116-100.ams2.redhat.com [10.36.116.100]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s999jWQ2002642; Thu, 9 Oct 2014 05:45:32 -0400 Received: by blade.nx (Postfix, from userid 1000) id D59532626B6; Thu, 9 Oct 2014 10:45:31 +0100 (BST) Date: Thu, 09 Oct 2014 09:45:00 -0000 From: Gary Benson To: Doug Evans Cc: gdb-patches Subject: Re: [PATCH 1/3] Remove spurious exceptions.h inclusions Message-ID: <20141009094531.GB6910@blade.nx> References: <1409586154-16196-1-git-send-email-gbenson@redhat.com> <1409586154-16196-2-git-send-email-gbenson@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00182.txt.bz2 Doug Evans wrote: > On Mon, Sep 1, 2014 at 11:42 AM, Gary Benson wrote: > > defs.h includes utils.h, and utils.h includes exceptions.h. All > > GDB .c files include defs.h as their first line, so no file other > > than utils.h needs to include exceptions.h. This commit removes > > all such inclusions. > > > > Doug, I Cc'd you on this one as you asked me to avoid giant > > mechanical ChangeLog entries but I couldn't figure out how I'd > > rewrite this one. > > For reference sake, > I said that for two reasons: > 1) to save you some typing > 2) to keep the S/N ratio of the ChangeLog file from dropping, and > in this case from dropping significantly. Yikes! > > > gdb/ChangeLog: > > > > * ada-lang.c: Do not include exceptions.h. > > * ada-valprint.c: Likewise. > > * amd64-tdep.c: Likewise. > > [...] > > I realize one of the guidelines for changelogs is to document every > file that's changed, but if we can agree that "All callers updated." > can apply to all callers in all files, then I don't see why we > couldn't be ok with something like the following for this case: > > * All .c files: Do not include exceptions.h. > > Yeah, it's not pedantically correct, not all .c files were touched. > But I can live with that given the alternative. I'll use this wording next time. Thanks, Gary -- http://gbenson.net/