From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1063 invoked by alias); 22 Sep 2014 13:03:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1037 invoked by uid 89); 22 Sep 2014 13:03:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 3 recipients X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 22 Sep 2014 13:03:27 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 66BBC1161DC; Mon, 22 Sep 2014 09:03:25 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id jFCngjtzHiIm; Mon, 22 Sep 2014 09:03:25 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 3391E116141; Mon, 22 Sep 2014 09:03:25 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id B86DF40E0C; Mon, 22 Sep 2014 09:03:24 -0400 (EDT) Date: Mon, 22 Sep 2014 13:03:00 -0000 From: Joel Brobecker To: Chen Gang , bug-readline@gnu.org Cc: amodra@gmail.com, Pedro Alves , jan.kratochvil@redhat.com, drow@false.org, ezannoni@kwikemart.cygnus.com, muller@sourceware.org, Nicholas Clifton , gdb-patches@sourceware.org, binutils@sourceware.org, macro@linux-mips.org Subject: Re: [PATCH] readline/search.c: Remove useless parameter '0' for rl_message() Message-ID: <20140922130324.GA4883@adacore.com> References: <541CF976.8090905@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <541CF976.8090905@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-09/txt/msg00659.txt.bz2 Hi Chen, > The related warning under Darwin x86_64: > > gcc -c -DHAVE_CONFIG_H -I. -I../../binutils-gdb/readline -DRL_LIBRARY_VERSION='"6.2"' -g -O2 ../../binutils-gdb/readline/search.c > ../../binutils-gdb/readline/search.c:213:24: warning: data argument not used by format string [-Wformat-extra-args] > rl_message ("%s", p, 0); > ~~~~ ^ > 1 warning generated. > > > readline/ChangeLog.gdb: > > * search.c (_rl_nsearch_init): Remove useless parameter '0' for > rl_message(). Because readline is a separate project from binutils/GDB, we prefer it if you would first submit the patch to the readline project first (bug-readline@gnu.org, in Cc: of this email), get it accepted there. Once pushed in the readline project, we can then merge your patch. Would you mind taking the lead in telling us when the patch is readline? Thank you! > Signed-off-by: Chen Gang > --- > readline/search.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/readline/search.c b/readline/search.c > index 04468fc..bf525e6 100644 > --- a/readline/search.c > +++ b/readline/search.c > @@ -210,7 +210,7 @@ _rl_nsearch_init (dir, pchar) > rl_end = rl_point = 0; > > p = _rl_make_prompt_for_search (pchar ? pchar : ':'); > - rl_message ("%s", p, 0); > + rl_message ("%s", p); > xfree (p); > > RL_SETSTATE(RL_STATE_NSEARCH); > -- > 1.8.5.2 (Apple Git-48) -- Joel