From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: palves@redhat.com (Pedro Alves)
Cc: emachado@linux.vnet.ibm.com (Edjunior Barbosa Machado),
gdb-patches@sourceware.org
Subject: [PUSHED][PR gdb/17384] Re: [PATCH] [PR tdep/17379] Fix internal-error when stack pointer is invalid
Date: Wed, 17 Sep 2014 15:34:00 -0000 [thread overview]
Message-ID: <201409171534.s8HFYjoe029725@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <54198678.10405@redhat.com> from "Pedro Alves" at Sep 17, 2014 02:02:48 PM
Pedro Alves wrote:
> On 09/17/2014 01:41 PM, Ulrich Weigand wrote:
> > Agreed, it doesn't make sense for safe_read_memory_integer to ever
> > print an error. In fact, it doesn't make sense for it to start
> > using a routine that raises exceptions and then attempt to catch it.
> > The following patch simplifies the whole logic by just using
> > target_read_memory directly. Does this look reasonable?
>
> Definitely reasonable. Looks great to me. Thanks for doing this.
OK, I've committed that patch now.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2014-09-17 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <54195D36.2080001@redhat.com>
2014-09-17 12:41 ` Ulrich Weigand
2014-09-17 13:03 ` Pedro Alves
2014-09-17 15:34 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201409171534.s8HFYjoe029725@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=emachado@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox