From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7388 invoked by alias); 15 Sep 2014 10:07:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7376 invoked by uid 89); 15 Sep 2014 10:07:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 15 Sep 2014 10:07:40 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8FA7ccu029986 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 15 Sep 2014 06:07:38 -0400 Received: from blade.nx (ovpn-116-123.ams2.redhat.com [10.36.116.123]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8FA7bRi020083; Mon, 15 Sep 2014 06:07:38 -0400 Received: by blade.nx (Postfix, from userid 1000) id DB11A2640D5; Mon, 15 Sep 2014 11:07:36 +0100 (BST) Date: Mon, 15 Sep 2014 10:07:00 -0000 From: Gary Benson To: Doug Evans Cc: Pedro Alves , gdb-patches Subject: Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid Message-ID: <20140915100736.GA13503@blade.nx> References: <21520.36381.756875.963606@ruffy2.mtv.corp.google.com> <20140911102659.GA17472@blade.nx> <5412DEB5.6020706@redhat.com> <21523.9502.168492.803068@ruffy2.mtv.corp.google.com> <54132B55.9000108@redhat.com> <21523.12189.134570.770432@ruffy2.mtv.corp.google.com> <5413305B.6020402@redhat.com> <21523.13993.986533.615240@ruffy2.mtv.corp.google.com> <54133939.70801@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00495.txt.bz2 Doug Evans wrote: > On Fri, Sep 12, 2014 at 11:19 AM, Pedro Alves wrote: > > On 09/12/2014 07:08 PM, Doug Evans wrote: > > > Pedro Alves wrote: > > > > I just now noticed the elephant in the room -- target_stop > > > > is asynchronous, doesn't wait for a stop, while and > > > > target_stop_ptid is synchronous. [...] > > > > > > If the above code is right, I think a clarifying comment is > > > required somewhere. It's odd that one can call > > > agent_run_command when the inferior may or may not be stopped > > > yet. [Or is there a bug here? - if I'm reading the gdbserver > > > version correctly it first waits for the inferior to stop] > > > > It's a bug. > > > > (Note that the GDB side interfaces with an out-of-tree > > agent, not GDBserver's agent. I don't know the status of > > that agent.) > > Data point that target_stop should be named target_stop_async? Ok, can I get a summary of this thread, I'm struggling to follow it. a) What should the functions be called: - target_stop_async / target_stop_wait - target_continue_async / target_continue_no_signal - something else? b) Is there a bug here I need to address? Thanks, Gary -- http://gbenson.net/