From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19009 invoked by alias); 12 Sep 2014 21:24:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18995 invoked by uid 89); 12 Sep 2014 21:24:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: sonata.ens-lyon.org Received: from sonata.ens-lyon.org (HELO sonata.ens-lyon.org) (140.77.166.138) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 12 Sep 2014 21:24:09 +0000 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 2B877200B7; Fri, 12 Sep 2014 23:24:06 +0200 (CEST) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B_L4Kf9wywW6; Fri, 12 Sep 2014 23:24:06 +0200 (CEST) Received: from type.youpi.perso.aquilenet.fr (11.123.68.86.rev.sfr.net [86.68.123.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id E4F66200B5; Fri, 12 Sep 2014 23:24:05 +0200 (CEST) Received: from samy by type.youpi.perso.aquilenet.fr with local (Exim 4.84) (envelope-from ) id 1XSYAE-0002S6-V5; Fri, 12 Sep 2014 23:13:54 +0200 Date: Fri, 12 Sep 2014 21:24:00 -0000 From: Samuel Thibault To: Joel Brobecker Cc: Thomas Schwinge , Gary Benson , bug-hurd@gnu.org, gdb-patches@sourceware.org Subject: Re: [PATCHv3,Hurd] Add hardware watch support Message-ID: <20140912211354.GI3202@type.youpi.perso.aquilenet.fr> Mail-Followup-To: Joel Brobecker , Thomas Schwinge , Gary Benson , bug-hurd@gnu.org, gdb-patches@sourceware.org References: <20140910224919.GP3244@type.youpi.perso.aquilenet.fr> <874mwcpvsy.fsf@schwinge.name> <20140912180054.GB4448@type.youpi.perso.aquilenet.fr> <20140912200141.GH4871@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140912200141.GH4871@adacore.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) X-SW-Source: 2014-09/txt/msg00467.txt.bz2 Joel Brobecker, le Fri 12 Sep 2014 13:01:41 -0700, a écrit : > > > Many thanks for persisting with this patch. > > > > I have to say I'm almost about to give up with submitting it. > > I would be very interested in hearing your honest feedback on this. > I know it took a long time, and we're not always very responsive, > but we try our best. If we could hear what made you feel this way, > I would like to try to see if there are any ways we can improve > the situation for you. I'm sorry I wrote it in such a harsh way while you were all polite in your requests. Actually it's an unfortunate combination of me also having a pending patch to the Linux kernel which has been waiting for several years, with only sporadic reviews, then a request for reshaping, and ended up with a "well, the way it is done will not fly" without very much details or discussion, and another pending patch to qemu, which apparently nobody has the time to review, while they are really interested in it. Seeing a submission to gdb getting stuck on missing line breaks got me a bit on my nerves. Fortunately it wasn't only about that, but also important changes, so I carried on, but having to resubmit only for missing spaces or new lines would have been really hard to me, since I don't really plan to submit many patches to gdb, and I know I'll always make this kind of mistakes since I'm submitting patches to a lot of various projects with very differing coding styles. What may help in the process would be to have a script which checks for style. The Linux kernel's checkpatch.pl is a very good approach, since one can get to check one's own style quite thoroughly before submitting. Samuel