From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2996 invoked by alias); 12 Sep 2014 20:23:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2983 invoked by uid 89); 12 Sep 2014 20:23:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 12 Sep 2014 20:23:44 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 86DC1116415; Fri, 12 Sep 2014 16:23:42 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 7l+BN0SHOjLM; Fri, 12 Sep 2014 16:23:42 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 49D81116414; Fri, 12 Sep 2014 16:23:42 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 17E2B40E17; Fri, 12 Sep 2014 13:23:41 -0700 (PDT) Date: Fri, 12 Sep 2014 20:23:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: "Maciej W. Rozycki" , Ulrich Weigand , GDB Patches Subject: Re: [IRIX] eliminate deprecated_insert_raw_breakpoint uses Message-ID: <20140912202341.GI4871@adacore.com> References: <201409101445.s8AEjILM007935@d06av02.portsmouth.uk.ibm.com> <54106C61.7040400@redhat.com> <54107860.6060301@redhat.com> <20140910224358.GS28404@adacore.com> <5410D83E.3070401@redhat.com> <20140911032712.GT28404@adacore.com> <54134A9D.3010107@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54134A9D.3010107@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-09/txt/msg00466.txt.bz2 > Thanks Joel. I've addressed that issue by marking the breakpoints > as disp_del_at_next_stop instead of deleting them immediately. > > Locally, I added a call to remove_solib_event_breakpoints_at_next_stop > to solib-svr4.c:svr4_handle_solib_event, to check that the breakpoint > does indeed end up removed, and that we don't crash. Adding a > call to remove_solib_event_breakpoints instead would crash in the > same way you saw on IRIX with the previous version of this patch. > > I avoided exposing insert_breakpoint_locations out of breakpoint.c by > adding a new create_and_insert_solib_event_breakpoint function > that is like create_solib_event_breakpoint but tries to insert the > breakpoint immediately. > > I figure that if someone wants to keep IRIX alive (either now, by > bringing it back from git), this will be a better base to start > from. > > So in interest of not having to wait for IRIX to be dropped, > I've gone ahead and pushed the patch below. I've just rebuilt GDB again, and I can confirm that the problem is fixed. After starting a program, I can still see the same list of shared libraries as before your change. Cheers! -- Joel