From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17925 invoked by alias); 12 Sep 2014 13:50:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17852 invoked by uid 89); 12 Sep 2014 13:50:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 12 Sep 2014 13:50:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id CC6D5116324; Fri, 12 Sep 2014 09:50:13 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 0hAx3RHmsYM5; Fri, 12 Sep 2014 09:50:13 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 83715116319; Fri, 12 Sep 2014 09:50:13 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 53EF840E17; Fri, 12 Sep 2014 06:50:12 -0700 (PDT) Date: Fri, 12 Sep 2014 13:50:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: Edjunior Barbosa Machado , gdb-patches@sourceware.org, Ulrich Weigand , Sergio Durigan Junior Subject: Re: [PATCH] [PR tdep/17379] Fix internal-error when stack pointer is invalid Message-ID: <20140912135012.GC4871@adacore.com> References: <1410490007-19756-1-git-send-email-emachado@linux.vnet.ibm.com> <5412C3F0.9000703@redhat.com> <20140912130051.GA4871@adacore.com> <5412F714.3040500@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5412F714.3040500@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-09/txt/msg00404.txt.bz2 > We still need to use gdb_run_cmd to cover remote testing, > so that'd be: > > gdb_test "" "Program received signal SIGSEGV.*" "run until SIGSEGV" > > ISTR that gdb_test doesn't allow empty command, but I may well > be mistaken. And if it doesn't, maybe it should. This is me pretending that I had noticed that the command was empty and knowing that this was still OK :-). But once you mentioned it, I knew I had already done something like that. See gdb.ada/bp_reset.exp: gdb_run_cmd gdb_test "" "Breakpoint $decimal, foo\\.nested_sub \\(\\).*" Doing a quick grep, we have a number of occurences where we use an empty command when calling gdb_test. And looking at gdb_test's implementation, it just passes the first argument to gdb_test_multiple, so it should indeed be equivalent. (phew, that was close! ;-)). -- Joel