From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1146 invoked by alias); 12 Sep 2014 08:39:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1136 invoked by uid 89); 12 Sep 2014 08:39:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: e06smtp10.uk.ibm.com Received: from e06smtp10.uk.ibm.com (HELO e06smtp10.uk.ibm.com) (195.75.94.106) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 12 Sep 2014 08:39:13 +0000 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 12 Sep 2014 09:39:10 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 12 Sep 2014 09:39:07 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id AB6BD17D8062 for ; Fri, 12 Sep 2014 09:41:08 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s8C8d6L946006278 for ; Fri, 12 Sep 2014 08:39:06 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s8C8d4FS029055 for ; Fri, 12 Sep 2014 02:39:06 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id s8C8d3wT028994; Fri, 12 Sep 2014 02:39:03 -0600 Message-Id: <201409120839.s8C8d3wT028994@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 12 Sep 2014 10:39:03 +0200 Subject: Re: [PATCH] [PR tdep/17379] Fix internal-error when stack pointer is invalid To: sergiodj@redhat.com (Sergio Durigan Junior) Date: Fri, 12 Sep 2014 08:39:00 -0000 From: "Ulrich Weigand" Cc: emachado@linux.vnet.ibm.com (Edjunior Barbosa Machado), gdb-patches@sourceware.org In-Reply-To: <877g195xuv.fsf@redhat.com> from "Sergio Durigan Junior" at Sep 11, 2014 11:19:52 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14091208-4966-0000-0000-0000014F9F85 X-SW-Source: 2014-09/txt/msg00384.txt.bz2 Sergio Durigan Junior wrote: > On Thursday, September 11 2014, Edjunior Barbosa Machado wrote: > > > Thanks Sergio for your feedback. I'm resending the patch with an additional > > testcase as you suggested. > > Nice, thanks :-). > > > diff --git a/gdb/testsuite/gdb.arch/powerpc-stackless.exp b/gdb/testsuite/gdb.arch/powerpc-stackless.exp > > new file mode 100644 > > index 0000000..f4b2a90 > [...] > > +standard_testfile powerpc-stackless.S > > Just another really minor nit, no need to resubmit the patch because of > this. You can write: > > standard_testfile .S > > Other than that, it is perfect. > > Thanks a lot! Thanks for the testcase (and the review)! Edjunior, the patch is OK to check in with the change Sergio suggested. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com