From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21334 invoked by alias); 11 Sep 2014 11:02:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21323 invoked by uid 89); 11 Sep 2014 11:02:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 11 Sep 2014 11:02:36 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8BB2XDN003088 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 11 Sep 2014 07:02:33 -0400 Received: from blade.nx (ovpn-116-85.ams2.redhat.com [10.36.116.85]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8BB2Wb3021194; Thu, 11 Sep 2014 07:02:32 -0400 Received: by blade.nx (Postfix, from userid 1000) id D4D302640D8; Thu, 11 Sep 2014 12:02:31 +0100 (BST) Date: Thu, 11 Sep 2014 11:02:00 -0000 From: Gary Benson To: Doug Evans Cc: gdb-patches@sourceware.org, Pedro Alves Subject: Re: [PATCH 5/9 v7] Introduce common-regcache.h Message-ID: <20140911110231.GC17472@blade.nx> References: <1409320299-6812-1-git-send-email-gbenson@redhat.com> <1409320299-6812-6-git-send-email-gbenson@redhat.com> <21520.37315.16694.677898@ruffy2.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21520.37315.16694.677898@ruffy2.mtv.corp.google.com> X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00353.txt.bz2 Doug Evans wrote: > Gary Benson writes: > > +/* Return the register cache associated with the thread specified > > + by PTID. This function must be provided by the client. */ > > Can you add a comment here explaining the ownership of the memory > object returned? E.g., is it cached "internally" to the function > so that the caller doesn't have to free it? That seems odd. We don't document other similar functions this way: I'm thinking GDB's get_current_arch, current_inferior, target_gdbarch, or gdbserver's current_process, current_target_desc. It seems the pattern is to note if the caller must free the object and to remain quiet otherwise. How about I change the comment to "Return _a_pointer_to_ the register cache..."? (underlines for emphasis here). Cheers, Gary -- http://gbenson.net/