Re: [PATCH 3/9 v7] Introduce target_{stop,continue}_ptid

Gary Benson
2014-09-15T10:07:43Z

Doug Evans wrote:
> On Fri, Sep 12, 2014 at 11:19 AM, Pedro Alves <palves@redhat.com> wrote:
> > On 09/12/2014 07:08 PM, Doug Evans wrote:
> > > Pedro Alves wrote:
> > > > I just now noticed the elephant in the room -- target_stop
> > > > is asynchronous, doesn't wait for a stop, while and
> > > > target_stop_ptid is synchronous. [...]
> > >
> > > If the above code is right, I think a clarifying comment is
> > > required somewhere. It's odd that one can call
> > > agent_run_command when the inferior may or may not be stopped
> > > yet. [Or is there a bug here? - if I'm reading the gdbserver
> > > version correctly it first waits for the inferior to stop]
> >
> > It's a bug.
> >
> > (Note that the GDB side interfaces with an out-of-tree
> > agent, not GDBserver's agent. I don't know the status of
> > that agent.)
>
> Data point that target_stop should be named target_stop_async?

Ok, can I get a summary of this thread, I'm struggling to follow it.

a) What should the functions be called:
- target_stop_async / target_stop_wait
- target_continue_async / target_continue_no_signal
- something else?

b) Is there a bug here I need to address?

Thanks,
Gary

--