From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 352 invoked by alias); 9 Sep 2014 21:25:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32460 invoked by uid 89); 9 Sep 2014 21:25:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: e06smtp10.uk.ibm.com Received: from e06smtp10.uk.ibm.com (HELO e06smtp10.uk.ibm.com) (195.75.94.106) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 09 Sep 2014 21:24:58 +0000 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 9 Sep 2014 22:24:55 +0100 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 9 Sep 2014 22:24:54 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 116502190045 for ; Tue, 9 Sep 2014 22:24:34 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s89LOrXv45220054 for ; Tue, 9 Sep 2014 21:24:53 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s89LOqX3025597 for ; Tue, 9 Sep 2014 15:24:53 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id s89LOpVQ025583; Tue, 9 Sep 2014 15:24:51 -0600 Message-Id: <201409092124.s89LOpVQ025583@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 09 Sep 2014 23:24:51 +0200 Subject: Re: eliminate deprecated_insert_raw_breakpoint. what's left. To: peterschauer@gmx.net (Peter Schauer) Date: Tue, 09 Sep 2014 21:25:00 -0000 From: "Ulrich Weigand" Cc: brobecker@adacore.com (Joel Brobecker), palves@redhat.com (Pedro Alves), gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <201409091237.s89CbnwW017512@licht.localdomain> from "Peter Schauer" at Sep 09, 2014 02:37:49 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14090921-4966-0000-0000-0000014751C1 X-SW-Source: 2014-09/txt/msg00250.txt.bz2 Peter Schauer wrote: > > > I think you could/should zap exec_one_dummy_insn, provided that you test > > > a dummy function call on the oldest AIX version that GDB has to support, > > > with a large aggregate parameter, which is passed by value. > > > > The only version I have ready access to is AIX 7.1, and on this there > > are no testsuite regression (and in fact, quite a number of failures > > seem to go away!) when zapping exec_one_dummy_insn. > > +1 for zapping exec_one_dummy_insn. > > > I'm not sure which versions we need to / should support in GDB; I guess > > the oldest version where the OS itself is still supported by IBM is 6.1. > > Maybe somebody could test if zapping exec_one_dummy_insn on AIX 6.1 > has any negative effect, and then be done with it. > > But even if that can't be tested, I am all in favour of getting rid > of it, perhaps with a detailed comment in the commit message for the > removal (or adding a link to this thread). I've now got access to an AIX 6.1 machine and repeated the experiment -- with the same result. No regressions when zapping exec_one_dummy_insn, and in fact about 100 FAILs fixed. So I think we should probably just do it at this point. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com