From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23699 invoked by alias); 8 Sep 2014 19:24:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23685 invoked by uid 89); 8 Sep 2014 19:24:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 08 Sep 2014 19:24:33 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id A7D6F11634A; Mon, 8 Sep 2014 15:24:31 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id SX+MfbcwSFyv; Mon, 8 Sep 2014 15:24:31 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7B2FA116342; Mon, 8 Sep 2014 15:24:31 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3DDE047592; Mon, 8 Sep 2014 12:24:32 -0700 (PDT) Date: Mon, 08 Sep 2014 19:24:00 -0000 From: Joel Brobecker To: Pedro Alves Cc: GDB Patches Subject: Re: eliminate deprecated_insert_raw_breakpoint. what's left. Message-ID: <20140908192432.GE28404@adacore.com> References: <540DEB7E.3000100@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <540DEB7E.3000100@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-09/txt/msg00205.txt.bz2 Hi Pedro, > The remaining users are: > > procfs.c: dbx_link_bpt = deprecated_insert_raw_breakpoint (target_gdbarch (), NULL, > > This is only compiled if SYS_syssgi is defined, which I believe means > MIPS IRIX. Do we still care about MIPS IRIX? > > solib-irix.c: base_breakpoint = deprecated_insert_raw_breakpoint (target_gdbarch (), I would be surprised if anyone still cared about IRIX anymore. I enjoyed working on that system, but I no longer have access to it, so can't support it anymore. > This could/should probably be converted to use create_solib_event_breakpoint. > Though see above. > > rs6000-nat.c: bp = deprecated_insert_raw_breakpoint (gdbarch, NULL, DUMMY_INSN_ADDR); > > This is AIX code. Looks like this can easily be converted to a > momentary breakpoint? I am actually wondering whether this is still needed. It could! So, the first thing I wanted to do was to run the testsuite without. I'm currently building GDB, which is taking forever, and will then run AdaCore's testsuite. I can certainly assist in making the change regardless! In terms of testing, I can only run AdaCore's testsuite because expect isn't working for me on AIX, and I lack the time to research it further. Although not ideal, it's been good enough for us. -- Joel