From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28572 invoked by alias); 1 Sep 2014 06:30:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28550 invoked by uid 89); 1 Sep 2014 06:30:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 01 Sep 2014 06:30:49 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 66BE7116223; Mon, 1 Sep 2014 02:30:47 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 46YlCTtrJ+KP; Mon, 1 Sep 2014 02:30:47 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id E85861161CA; Mon, 1 Sep 2014 02:30:46 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 9094F4758E; Mon, 1 Sep 2014 08:30:47 +0200 (CEST) Date: Mon, 01 Sep 2014 06:30:00 -0000 From: Joel Brobecker To: Siva Chandra Cc: Doug Evans , gdb-patches Subject: Re: [PATCH v2] Fix xmethod Python so that it works with Python 3 Message-ID: <20140901063047.GA5026@adacore.com> References: <21485.14738.947462.758709@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-09/txt/msg00006.txt.bz2 > >> > ChangeLog: > >> > 2014-08-14 Siva Chandra Reddy > >> > > >> > gdb/ > >> > > >> > * python/lib/gdb/command/xmethods.py (set_xm_status1): Use the > >> > 'items' methods instead of 'iteritems' method on dictionaries. > >> > > >> > gdb/testsuite/ > >> > > >> > * gdb.python/py-xmethods.py (A_getarrayind) > >> > (E_method_char_worker.__call__, E_method_int_worker.__call__): > >> > Use 'print' with function call syntax. > >> > (E_method_matcher.match): Fix tab vs space indentation mixup. > >> > >> LGTM > > > > Pushed 940df408121be31beed22ef7a5ad133cb1592726. > > Missed asking: OK for 7.8 branch? Yes. Pleasae make sure to update the branch's wiki as well (section "Fixes in 7.8.1" - you might need to create a PR for that). Thanks, -- Joel