From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13243 invoked by alias); 29 Aug 2014 12:49:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13231 invoked by uid 89); 29 Aug 2014 12:49:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 29 Aug 2014 12:49:49 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7TCnlgN021596 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 29 Aug 2014 08:49:47 -0400 Received: from host2.jankratochvil.net (ovpn-113-193.phx2.redhat.com [10.3.113.193]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7TCnidn017924 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Fri, 29 Aug 2014 08:49:46 -0400 Date: Fri, 29 Aug 2014 12:49:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [patch] [testsuite] Fix running in-src-dir in the same directory twice Message-ID: <20140829124943.GA13893@host2.jankratochvil.net> References: <20140828211010.GA4960@host2.jankratochvil.net> <21503.42231.813828.804626@ruffy2.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21503.42231.813828.804626@ruffy2.mtv.corp.google.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00640.txt.bz2 On Thu, 28 Aug 2014 23:53:59 +0200, Doug Evans wrote: > Tests can prematurely terminate for various unanticipatable reasons. > Can this be solved by making sure any possibly hazardous left > over files are cleaned up at start? Do you mean start of argv0-symlink.exp? There was/is already: remote_file host delete [standard_output_file $filelink] set status [remote_exec host "ln -sf ${testfile} [standard_output_file $filelink]"] Or do you mean moving this 'remote_file host delete' to the very start of the testcase - that is just moving it before [build_executable]? I do not know if there is a possibility to register some cleanup function for the current testcase. But also I do not know how the testcase could end by a different codepath than those I protected in the patch. Thanks, Jan