From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25775 invoked by alias); 20 Aug 2014 19:16:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25764 invoked by uid 89); 20 Aug 2014 19:16:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Aug 2014 19:16:32 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KJGKFk004803 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Aug 2014 15:16:21 -0400 Received: from blade.nx (ovpn-116-90.ams2.redhat.com [10.36.116.90]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7KJGJI6003591; Wed, 20 Aug 2014 15:16:19 -0400 Received: by blade.nx (Postfix, from userid 1000) id 1AE222640D2; Wed, 20 Aug 2014 20:16:19 +0100 (BST) Date: Wed, 20 Aug 2014 19:16:00 -0000 From: Gary Benson To: "Frank Ch. Eigler" Cc: Mike Frysinger , Steve Ellcey , Doug Evans , gdb-patches , Pedro Alves Subject: Re: [PATCH 4/5 v7] Introduce common-debug.h Message-ID: <20140820191618.GC23764@blade.nx> References: <20140819091220.GB6493@blade.nx> <1408490530.31355.15.camel@ubuntu-sellcey> <20140820085243.GA2694@blade.nx> <15329331.NicJ8HFAzI@vapier> <20140820120934.GA26854@blade.nx> <20140820133155.GB5363@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140820133155.GB5363@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00427.txt.bz2 Frank Ch. Eigler wrote: > > > [...] > > > i'm fine with updating sim/common/sim-trace.h with that idea: > > > #define debug_printf sim_debug_printf > > > all the symbols coming out of the sim really should be namespaced > > IMHO, names this generic should be avoided in *both* application (gdb) > and library (sim), lest another future library come & interfere later. Yeah, I should know this by now :/ > > Great. I can put together a patch if you like (or I can make the > > change, or you can... whatever's easiest!) I don't know much about > > SIM... is there a list to mail patches to? And, is its upstream > > repo the same as binutils+GDB or is it imported from somewhere else > > like libiberty? > > sim is part of the binutils-gdb.git repo, patches here fine. The > main problem with testing the sim for changes like this is its > inability to easily build all targets, and its aggressive use of > macros, which makes it hard to know you've actually covered all the > cases for a symbol-rename. Yuck :( Frank, if you're not ok with the patch I just mailed then let me know and I'll figure something out when I get back from PTO. Thanks, Gary -- http://gbenson.net/