From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16589 invoked by alias); 20 Aug 2014 12:09:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16577 invoked by uid 89); 20 Aug 2014 12:09:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Aug 2014 12:09:47 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KC9ZVF012362 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Aug 2014 08:09:35 -0400 Received: from blade.nx (ovpn-116-90.ams2.redhat.com [10.36.116.90]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7KC9YZr024320; Wed, 20 Aug 2014 08:09:35 -0400 Received: by blade.nx (Postfix, from userid 1000) id 2DABA2640D5; Wed, 20 Aug 2014 13:09:34 +0100 (BST) Date: Wed, 20 Aug 2014 12:09:00 -0000 From: Gary Benson To: Mike Frysinger Cc: Steve Ellcey , Doug Evans , gdb-patches , Pedro Alves , "Frank Ch. Eigler" Subject: Re: [PATCH 4/5 v7] Introduce common-debug.h Message-ID: <20140820120934.GA26854@blade.nx> References: <20140819091220.GB6493@blade.nx> <1408490530.31355.15.camel@ubuntu-sellcey> <20140820085243.GA2694@blade.nx> <15329331.NicJ8HFAzI@vapier> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15329331.NicJ8HFAzI@vapier> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00396.txt.bz2 Mike Frysinger wrote: > On Wed 20 Aug 2014 09:52:43 Gary Benson wrote: > > I don't see any callers for SIM's debug_printf. Is this dead code > > that can be removed, or is it provided as a convenience/library > > function? > > it is not currently being used, but it really really should be in > some targets Ok. > > Steve, you can probably work around this for now by adding: > > > > #define debug_printf gdb_debug_printf > > > > at the top of GDB's common/common-debug.h. If SIM's debug_printf > > cannot be removed then maybe we will have to add some hack like > > this to GDB permanently. > > i'm fine with updating sim/common/sim-trace.h with that idea: > #define debug_printf sim_debug_printf > > all the symbols coming out of the sim really should be namespaced Great. I can put together a patch if you like (or I can make the change, or you can... whatever's easiest!) I don't know much about SIM... is there a list to mail patches to? And, is its upstream repo the same as binutils+GDB or is it imported from somewhere else like libiberty? Cheers, Gary -- http://gbenson.net/