From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17353 invoked by alias); 19 Aug 2014 13:48:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17341 invoked by uid 89); 19 Aug 2014 13:48:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 19 Aug 2014 13:48:13 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9623A1162E0; Tue, 19 Aug 2014 09:48:11 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id CwGjELcJy8eN; Tue, 19 Aug 2014 09:48:11 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 7280E1162D4; Tue, 19 Aug 2014 09:48:11 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id D6F9E410E0; Tue, 19 Aug 2014 15:48:10 +0200 (CEST) Date: Tue, 19 Aug 2014 13:48:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Set breakpoint on the right line Message-ID: <20140819134810.GJ1773@adacore.com> References: <1407806302-14295-1-git-send-email-yao@codesourcery.com> <20140819063838.GB1773@adacore.com> <53F3519B.3080905@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53F3519B.3080905@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-08/txt/msg00348.txt.bz2 > > I think you are right, but can you describe the error you are getting > > with arm-none-eabi? > > Sure, the fail is shown as below: > > continue^M > Continuing.^M > ^M > *** EXIT code 0^M > [Inferior 1 (Remote target) exited normally]^M > (gdb) FAIL: gdb.base/watchpoint-hw-hit-once.exp: continue to break-at-exit (the program exited) > > I also copy it in the commit log. Patch is pushed in. I actually didn't pre-approve, but never mind :-). I think I understand, now. The problem using the first break-at-exit line was that the watchpoint would be triggering at the same location the breakpoint was inserted. So the "continue" test right after would never hit that breakpoint. If my understanding is correct, the patch is officially approved :). -- Joel