From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31953 invoked by alias); 19 Aug 2014 09:12:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31917 invoked by uid 89); 19 Aug 2014 09:12:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 19 Aug 2014 09:12:26 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7J9CL1E013209 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Aug 2014 05:12:22 -0400 Received: from blade.nx (ovpn-116-90.ams2.redhat.com [10.36.116.90]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7J9CKHr021726; Tue, 19 Aug 2014 05:12:21 -0400 Received: by blade.nx (Postfix, from userid 1000) id 495932640D5; Tue, 19 Aug 2014 10:12:20 +0100 (BST) Date: Tue, 19 Aug 2014 09:12:00 -0000 From: Gary Benson To: Doug Evans Cc: gdb-patches , Pedro Alves Subject: Re: [PATCH 4/5 v7] Introduce common-debug.h Message-ID: <20140819091220.GB6493@blade.nx> References: <1407923779-22149-1-git-send-email-gbenson@redhat.com> <1407923779-22149-5-git-send-email-gbenson@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00339.txt.bz2 Doug Evans wrote: > On Wed, Aug 13, 2014 at 2:56 AM, Gary Benson wrote: > > This introduces common-debug.h. This holds the functions > > debug_printf and debug_vprintf, two functions that the common > > code can use to print debugging messages. Clients of the common > > code are expected to implement debug_vprintf; a debug_vprintf > > function is written from scratch for GDB, and gdbserver's > > existing debug_printf is repurposed as debug_vprintf. > > > > common/agent.c is changed to use debug_vprintf rather than > > defining the macro DEBUG_AGENT depending on GDBSERVER. > > > > nat/i386-dregs.c is changed to use the externally-implemented > > debug_printf, rather than defining it itself. > > > > gdb/ > > 2014-08-13 Tom Tromey > > Gary Benson > > > > * common/common-debug.h: New file. > > * common/common-debug.c: Likewise. > > * debug.c: Likewise. > > * Makefile.in (SFILES): Add common/common-debug.c. > > (HFILES_NO_SRCDIR): Add common/common-debug.h. > > (COMMON_OBS): Add common-debug.o and debug.o. > > (common-debug.o): New rule. > > * common/common-defs.h: Include common-debug.h. > > * common/agent.c (debug_agent_printf): New function. > > (DEBUG_AGENT): Redefine. > > * nat/i386-dregs.c (debug_printf): Undefine. > > > > gdb/gdbserver/ > > 2014-08-13 Tom Tromey > > Gary Benson > > > > * Makefile.in (SFILES): Add common/common-debug.c. > > (OBS): Add common-debug.o. > > (common-debug.o): New rule. > > * debug.h (debug_printf): Don't declare. > > * debug.c (debug_printf): Renamed and rewritten as... > > (debug_vprintf): New function. > > LGTM I've pushed this series up to here. Thanks for reviewing this Doug. Cheers, Gary -- http://gbenson.net/