Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Will Newton <will.newton@linaro.org>
Cc: gdb-patches@sourceware.org, binutils@sourceware.org
Subject: Re: [RFC] src-release.sh: Convert src-release to a shell script
Date: Fri, 15 Aug 2014 12:49:00 -0000	[thread overview]
Message-ID: <20140815124917.GB6037@adacore.com> (raw)
In-Reply-To: <1407419590-27223-1-git-send-email-will.newton@linaro.org>

> 2014-08-07  Will Newton  <will.newton@linaro.org>
> 
> 	* src-release.sh: New file.

Generally speaking, I tend to agree that a makefile is slightly
overkill for this task. The contents of the makefile is fairly
straightforward though, and outside of variable VEC in the makefile,
you script doesn't look any simpler than the makefile... What
I appreciate, however, is the lack of make recursions (with
the associated multiple "make" processes).

Give it another week for people to comment on, and then let's get
this in (I'll take care of talking to Tristan when he comes back).
Also, let's delete the old src-release script.

Some relatively trivial comments below:

> diff --git a/src-release.sh b/src-release.sh
> new file mode 100755
> index 0000000..3d41269
> --- /dev/null
> +++ b/src-release.sh
> @@ -0,0 +1,353 @@
> +#!/bin/bash

Can you use /usr/bin/env? People trying to create tarballs for their
own might not be doing it on a GNU/Linux machine, and so bash might
be installed elsewhere.

> +#   Copyright (C) 1990-2014 Free Software Foundation
> +#
> +# This file is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 2 of the License, or
> +# (at your option) any later version.
> +# 
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +# 
> +# You should have received a copy of the GNU General Public License
> +# along with this program; if not, write to the Free Software
> +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

The copyright year range looks correct to me, but the license
should be GPLv3.

-- 
Joel


  reply	other threads:[~2014-08-15 12:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-07 13:53 Will Newton
2014-08-15 12:49 ` Joel Brobecker [this message]
2014-08-26 10:40   ` Will Newton
2014-08-27  6:06     ` Joel Brobecker
2014-08-27 12:52       ` Will Newton
2014-08-27 17:13         ` Hans-Peter Nilsson
2014-08-27 18:02           ` Will Newton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140815124917.GB6037@adacore.com \
    --to=brobecker@adacore.com \
    --cc=binutils@sourceware.org \
    --cc=gdb-patches@sourceware.org \
    --cc=will.newton@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox