Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: yao@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: Warnings in native MinGW32 build of GDB 7.8
Date: Wed, 13 Aug 2014 18:26:00 -0000	[thread overview]
Message-ID: <20140813182655.GH4881@adacore.com> (raw)
In-Reply-To: <20140813181033.GG4881@adacore.com>

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

> > I can do the 1st and the 3rd parts, but I'd prefer not to touch
> > gdbarch.sh.  Could one of you please do that?

Attached is a patch that does that. Can you confirm it fixes your
warnings?

-- 
Joel

[-- Attachment #2: 0001-Add-frame.h-include-in-gdbarch.h.patch --]
[-- Type: text/x-diff, Size: 1220 bytes --]

From ee8948e61a8047d67cf8ad32d3259dbe7951a527 Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Wed, 13 Aug 2014 11:15:00 -0700
Subject: [PATCH] Add "frame.h" #include in gdbarch.h.

This include is needed because of gdbarch_dummy_id needs the full
definition of struct frame_id.

gdb/ChangeLog:

        * gdbarch.sh: #include "frame.h" in gdbarch.h.  Delete "struct
        frame_info" advance declaration.

Tested on x86_64-linux by rebuilding GDB.
---
 gdb/gdbarch.h  | 3 ++-
 gdb/gdbarch.sh | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/gdb/gdbarch.h b/gdb/gdbarch.h
index 5388e6e..0303b2e 100644
--- a/gdb/gdbarch.h
+++ b/gdb/gdbarch.h
@@ -35,9 +35,10 @@
 #ifndef GDBARCH_H
 #define GDBARCH_H
 
+#include "frame.h"
+
 struct floatformat;
 struct ui_file;
-struct frame_info;
 struct value;
 struct objfile;
 struct obj_section;
diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh
index 61d0781..2a8bca8 100755
--- a/gdb/gdbarch.sh
+++ b/gdb/gdbarch.sh
@@ -1124,9 +1124,10 @@ cat <<EOF
 #ifndef GDBARCH_H
 #define GDBARCH_H
 
+#include "frame.h"
+
 struct floatformat;
 struct ui_file;
-struct frame_info;
 struct value;
 struct objfile;
 struct obj_section;
-- 
1.9.1


  reply	other threads:[~2014-08-13 18:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-09 14:10 Eli Zaretskii
2014-08-13  4:11 ` Yao Qi
2014-08-13 15:21   ` Eli Zaretskii
2014-08-13 17:42     ` Joel Brobecker
2014-08-13 18:02       ` Eli Zaretskii
2014-08-13 18:10         ` Joel Brobecker
2014-08-13 18:26           ` Joel Brobecker [this message]
2014-08-13 18:48             ` Eli Zaretskii
2014-08-15 12:33               ` Joel Brobecker
2014-08-15 14:22                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140813182655.GH4881@adacore.com \
    --to=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox