From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13936 invoked by alias); 7 Aug 2014 12:39:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13926 invoked by uid 89); 7 Aug 2014 12:39:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 07 Aug 2014 12:39:03 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s77Cd0Ji015155 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Aug 2014 08:39:00 -0400 Received: from blade.nx (ovpn-116-43.ams2.redhat.com [10.36.116.43]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s77Ccxuo000896; Thu, 7 Aug 2014 08:39:00 -0400 Received: by blade.nx (Postfix, from userid 1000) id 2F3112640E0; Thu, 7 Aug 2014 13:38:59 +0100 (BST) Date: Thu, 07 Aug 2014 12:39:00 -0000 From: Gary Benson To: Doug Evans Cc: gdb-patches@sourceware.org, Pedro Alves , Tom Tromey Subject: Re: [PATCH 11/11 v5] Remove one GDBSERVER use from linux-waitpid.c Message-ID: <20140807123859.GB19737@blade.nx> References: <1406888377-25795-1-git-send-email-gbenson@redhat.com> <1406888377-25795-12-git-send-email-gbenson@redhat.com> <21474.30047.278277.20526@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21474.30047.278277.20526@ruffy.mtv.corp.google.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00137.txt.bz2 Doug Evans wrote: > Gary Benson writes: > > @@ -35,6 +29,8 @@ static inline void > > linux_debug (const char *format, ...) > > { > > #ifdef GDBSERVER > > + extern int debug_threads; > > + > > Recognizing that this is a temporary hack, ok by me. > Can I ask you to add a FIXME here though? I added: /* FIXME: This conditional code and hacky extern are necessary now, but should be removed when GDB's and gdbserver's Linux thread_db implementations are unified and moved into the nat directory. */ Thanks, Gary -- http://gbenson.net/