From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31125 invoked by alias); 7 Aug 2014 12:28:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31115 invoked by uid 89); 7 Aug 2014 12:28:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 07 Aug 2014 12:28:09 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s77CS771010503 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Aug 2014 08:28:07 -0400 Received: from blade.nx (ovpn-116-43.ams2.redhat.com [10.36.116.43]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s77CS6Z3005199; Thu, 7 Aug 2014 08:28:07 -0400 Received: by blade.nx (Postfix, from userid 1000) id 0A0F72640E0; Thu, 7 Aug 2014 13:28:05 +0100 (BST) Date: Thu, 07 Aug 2014 12:28:00 -0000 From: Gary Benson To: Doug Evans Cc: gdb-patches@sourceware.org, Pedro Alves , Tom Tromey Subject: Re: [PATCH 10/11 v5] Remove GDBSERVER uses from i386-dregs.c Message-ID: <20140807122805.GA19737@blade.nx> References: <1406888377-25795-1-git-send-email-gbenson@redhat.com> <1406888377-25795-11-git-send-email-gbenson@redhat.com> <21474.29901.308670.5969@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21474.29901.308670.5969@ruffy.mtv.corp.google.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00136.txt.bz2 Doug Evans wrote: > Gary Benson writes: > > -#ifndef GDBSERVER > > /* Whether or not to print the mirrored debug registers. */ > > extern int debug_hw_points; > > -#endif > > Since externs should live in headers, and since this is a cleanup > patch, can I impose on you a request to move debug_hw_points to a > header. Seems like i386-dregs.h is the best place. > > The variable could even arguably be defined in i386-dregs.c, though > I'm not sure if/how people would want i386-nat.c to change. Plus > add x86 or some such to the variable's name. I'd leave this part to > another pass. i386-dregs doesn't work for debug_hw_points, as it's also used by the aarch64-linux code. It's handled fairly messily at present (it's global in gdbserver, in server.[ch], but local to some ports in GDB) which I guess I why I left it why it was when I did the i386-dregs work. Since it's global in gdbserver it probably should just be global. I'll move the extern to common-debug.h, and the definition to common-debug.c. Thanks, Gary -- http://gbenson.net/