From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21027 invoked by alias); 7 Aug 2014 10:42:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21016 invoked by uid 89); 7 Aug 2014 10:42:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 07 Aug 2014 10:42:16 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s77AgDRN002488 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Aug 2014 06:42:13 -0400 Received: from blade.nx (ovpn-116-43.ams2.redhat.com [10.36.116.43]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s77AgC77010855; Thu, 7 Aug 2014 06:42:12 -0400 Received: by blade.nx (Postfix, from userid 1000) id 866B12640E0; Thu, 7 Aug 2014 11:42:11 +0100 (BST) Date: Thu, 07 Aug 2014 10:42:00 -0000 From: Gary Benson To: Doug Evans Cc: gdb-patches@sourceware.org, Pedro Alves , Tom Tromey Subject: Re: [PATCH 06/11 v5] Add target/symbol.h Message-ID: <20140807104211.GA6984@blade.nx> References: <1406888377-25795-1-git-send-email-gbenson@redhat.com> <1406888377-25795-7-git-send-email-gbenson@redhat.com> <21474.28421.76398.827681@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21474.28421.76398.827681@ruffy.mtv.corp.google.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00135.txt.bz2 Doug Evans wrote: > Gary Benson writes: > > +/* Find a symbol that matches NAME. Limit the search to OBJFILE if > > + OBJFILE is non-NULL and the implementation supports limiting the > > + search to specific object files. If a match is found, store the > > + matching symbol's address in ADDR and return nonzero. Return zero > > + if no symbol matching NAME is found. Raise an exception if OBJFILE > > + is non-NULL and the implementation does not support limiting > > + searches to specific object files. */ > > + > > +extern int target_look_up_symbol (const char *name, CORE_ADDR *addr, > > + struct objfile *objfile); > > Can this comment spell out that either a mangled or demangled > form of the symbol is allowed for NAME? > [assuming that that is indeed the case] It is the case. I'll update the comment. > Also, the target/target.h memory routines return zero for success > and a non-zero error code for failure. E.g., > > +/* Read LEN bytes of target memory at address MEMADDR, placing the > + results in GDB's memory at MYADDR. Return zero for success, > + nonzero if any error occurs. Implementations of this function may > + define and use their own error codes, but functions in the common, > + nat and target directories must treat the return code as opaque. > + No guarantee is made about the contents of the data at MYADDR if > + any error occurs. */ > + > +extern int target_read_memory (CORE_ADDR memaddr, gdb_byte *myaddr, > + ssize_t len); > > Do we want to be consistent here, and have the same results for > target_look_up_symbol? [and throughout the target API] That seems reasonable to me, I'll make the change. Thanks, Gary -- http://gbenson.net/