From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26825 invoked by alias); 7 Aug 2014 09:22:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26811 invoked by uid 89); 7 Aug 2014 09:22:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 07 Aug 2014 09:22:55 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s779MpoB008982 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Aug 2014 05:22:52 -0400 Received: from blade.nx (ovpn-116-43.ams2.redhat.com [10.36.116.43]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s779Mpnf028873; Thu, 7 Aug 2014 05:22:51 -0400 Received: by blade.nx (Postfix, from userid 1000) id 672642640E0; Thu, 7 Aug 2014 10:22:50 +0100 (BST) Date: Thu, 07 Aug 2014 09:22:00 -0000 From: Gary Benson To: Doug Evans Cc: gdb-patches@sourceware.org, Pedro Alves , Tom Tromey Subject: Re: [PATCH 04/11 v5] Introduce and use debug_printf and debug_vprintf Message-ID: <20140807092250.GA4697@blade.nx> References: <1406888377-25795-1-git-send-email-gbenson@redhat.com> <1406888377-25795-5-git-send-email-gbenson@redhat.com> <21474.24819.964899.502265@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21474.24819.964899.502265@ruffy.mtv.corp.google.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00133.txt.bz2 Doug Evans wrote: > Gary Benson writes: > > +/* A stdarg wrapper for debug_vprintf. */ > > + > > +static void ATTRIBUTE_PRINTF (1, 2) > > +debug_agent_print (const char *fmt, ...) > > Nit: debug_agent_printf ? I will change this. > > +/* Print a formatted message to the appropriate channel for debugging > > + output for the client. */ > > IWBN to include mention that this function must be provided by the client. > [I'm not sure what other similar decls do, but IWBN if they all had > a similar comment.] That's a good idea. I'll add this here and everywhere else that needs it. Thanks, Gary -- http://gbenson.net/