From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3025 invoked by alias); 7 Aug 2014 08:15:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3004 invoked by uid 89); 7 Aug 2014 08:15:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 07 Aug 2014 08:15:10 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s778F8W7004302 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 7 Aug 2014 04:15:08 -0400 Received: from blade.nx (ovpn-116-43.ams2.redhat.com [10.36.116.43]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s778F7qK027714; Thu, 7 Aug 2014 04:15:07 -0400 Received: by blade.nx (Postfix, from userid 1000) id B2F262640E0; Thu, 7 Aug 2014 09:15:06 +0100 (BST) Date: Thu, 07 Aug 2014 08:15:00 -0000 From: Gary Benson To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 00/13] Include some headers in common-defs.h Message-ID: <20140807081506.GB30420@blade.nx> References: <1406644635-1011-1-git-send-email-gbenson@redhat.com> <21474.25924.497358.887068@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21474.25924.497358.887068@ruffy.mtv.corp.google.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00131.txt.bz2 Doug Evans wrote: > Gary Benson writes: > > This series builds on my "config.h rationalization" series that is > > currently under review [1]. > > > > Each patch adds one #include line to common-defs.h and removes all > > other inclusions of that file in all files that include either > > defs.h or server.h. Patches 1-11 deal with files that are already > > included by both defs.h and server.h; these patches don't really > > change anything about the build. Patches 12 and 13 add > > gdb_assert.h and string.h respectively. These are included by > > server.h but not by defs.h, but both are included in hundreds of > > files so I think they are good candidates for global inclusion. > > > > There are three more files that are included by both defs.h and > > server.h that I have not dealt with in this series. errno.h and > > alloca.h are both handled completely differently by defs.h and > > server.h: moving these headers to common-defs.h should be done, > > but will require merging the configury. The final file, > > print-utils.h, is included indirectly by both defs.h and server.h > > but cannot be merged without some of the "Common code cleanups" > > series [2]. That needs some rewriting, so I'll add that to > > common-defs.h as part of the next version of that series. > > > > Is this ok to commit? > > > > Thanks, > > Gary > > > > -- > > [1] https://sourceware.org/ml/gdb-patches/2014-07/msg00670.html > > [2] https://sourceware.org/ml/gdb-patches/2014-07/msg00427.html > > LGTM Pushed. Thank you for the review! Cheers, Gary -- http://gbenson.net/