From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18173 invoked by alias); 6 Aug 2014 17:05:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18158 invoked by uid 89); 6 Aug 2014 17:05:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 06 Aug 2014 17:05:19 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s76H5Foe021966 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 6 Aug 2014 13:05:15 -0400 Received: from blade.nx (ovpn-116-90.ams2.redhat.com [10.36.116.90]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s76H5Ew6021683; Wed, 6 Aug 2014 13:05:14 -0400 Received: by blade.nx (Postfix, from userid 1000) id D21D72640DF; Wed, 6 Aug 2014 18:05:13 +0100 (BST) Date: Wed, 06 Aug 2014 17:05:00 -0000 From: Gary Benson To: Doug Evans Cc: gdb-patches@sourceware.org, Pedro Alves , Tom Tromey Subject: Re: [PATCH 03/11 v5] Move print-utils.h to common-defs.h Message-ID: <20140806170513.GA15176@blade.nx> References: <1406888377-25795-1-git-send-email-gbenson@redhat.com> <1406888377-25795-4-git-send-email-gbenson@redhat.com> <21474.23819.618023.581716@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21474.23819.618023.581716@ruffy.mtv.corp.google.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00105.txt.bz2 Doug Evans wrote: > Gary Benson writes: > > diff --git a/gdb/common/common-defs.h b/gdb/common/common-defs.h > > index 5543e4c..66c0d21 100644 > > --- a/gdb/common/common-defs.h > > +++ b/gdb/common/common-defs.h > > @@ -43,5 +43,6 @@ > > #include "gdb_assert.h" > > #include "errors.h" > > #include "common-types.h" > > +#include "print-utils.h" > > > > #endif /* COMMON_DEFS_H */ > > It's a bit odd to see common-defs.h include print-utils.h and not > common-utils.h. I see it gets included by gdb_assert.h, but > as a reader I'm still left with the question of wondering what's > going on and wanting to spend time digging into it. > I wonder if we can improve this somehow. > [No need to work on that in this patch set though.] This version of this series needs to be applied on top of this series: https://sourceware.org/ml/gdb-patches/2014-07/msg00736.html common-utils.h is moved into common-defs.h in patch 11 of that series (and all other inclusions are removed, including the one in gdb_assert.h) If it helps I have both series in a branch: https://github.com/gbenson/binutils-gdb/tree/common-defs Cheers, Gary -- http://gbenson.net/