From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14114 invoked by alias); 6 Aug 2014 16:29:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14102 invoked by uid 89); 6 Aug 2014 16:29:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 06 Aug 2014 16:29:46 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s76GThpt032534 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 6 Aug 2014 12:29:44 -0400 Received: from blade.nx (ovpn-116-90.ams2.redhat.com [10.36.116.90]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s76GThgE002352; Wed, 6 Aug 2014 12:29:43 -0400 Received: by blade.nx (Postfix, from userid 1000) id 929BD2640DF; Wed, 6 Aug 2014 17:29:40 +0100 (BST) Date: Wed, 06 Aug 2014 16:29:00 -0000 From: Gary Benson To: Doug Evans Cc: gdb-patches@sourceware.org, Pedro Alves , Tom Tromey Subject: Re: [PATCH 01/11 v5] Introduce common/errors.h Message-ID: <20140806162940.GA14412@blade.nx> References: <1406888377-25795-1-git-send-email-gbenson@redhat.com> <1406888377-25795-2-git-send-email-gbenson@redhat.com> <21474.21959.405429.703789@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21474.21959.405429.703789@ruffy.mtv.corp.google.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00095.txt.bz2 Doug Evans wrote: > Gary Benson writes: > > +#ifdef GDBSERVER > > +#include "server.h" > > +#else > > +#include "defs.h" > > +#endif > > +#include "errors.h" > > Nit: The introductory email to this patch series didn't mention > this instance of #ifdef GDBSERVER. Needed? It's removed in patch 8 of the series. It's only here to ensure the series builds at every step. Thanks, Gary -- http://gbenson.net/