From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21434 invoked by alias); 6 Aug 2014 13:17:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21421 invoked by uid 89); 6 Aug 2014 13:17:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 06 Aug 2014 13:17:38 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 808AB1164B7; Wed, 6 Aug 2014 09:17:36 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id i0ey9TNa7vFg; Wed, 6 Aug 2014 09:17:36 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5B4EC1165CF; Wed, 6 Aug 2014 09:17:36 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 68BC1410E6; Wed, 6 Aug 2014 06:17:35 -0700 (PDT) Date: Wed, 06 Aug 2014 13:17:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Rename variable with confusing name Message-ID: <20140806131735.GB5204@adacore.com> References: <1406930946-28195-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1406930946-28195-1-git-send-email-simon.marchi@ericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-08/txt/msg00083.txt.bz2 > I saw this gem of not so legible code in solib-svr4.c (scan_dyntag): > > if (dyn_tag == dyntag) > > and thought it deserved a small rename. Indeed! > 2014-08-01 Simon Marchi > > * solib-svr4.c (scan_dyntag): Rename dyntag, dyn_tag and > dyn_ptr variables. Approved, and many thanks for this small but important improvement. We also have the same issue in scan_dyntag_auxv; if you feel inclined to it, the same change is pre-approved there. -- Joel