From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5882 invoked by alias); 31 Jul 2014 20:42:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5871 invoked by uid 89); 31 Jul 2014 20:42:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 31 Jul 2014 20:42:45 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8298A1162F0; Thu, 31 Jul 2014 16:42:43 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id FlDlPliGF6kR; Thu, 31 Jul 2014 16:42:43 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 321F9116229; Thu, 31 Jul 2014 16:42:43 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 3812747740; Thu, 31 Jul 2014 13:42:42 -0700 (PDT) Date: Thu, 31 Jul 2014 20:58:00 -0000 From: Joel Brobecker To: Doug Evans Cc: Jan Kratochvil , gdb-patches Subject: Re: [PATCH] Delete struct inferior_suspend_state Message-ID: <20140731204242.GH14672@adacore.com> References: <20140731193050.GA7927@host2.jankratochvil.net> <20140731200529.GG14672@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-07/txt/msg00836.txt.bz2 > Comments don't necessarily fare much better. > Consider the 23 year old TODO. 1/2 :-) > ref: https://sourceware.org/ml/gdb-patches/2014-07/msg00832.html That is sometimes true, but not always. Comments are easier to search/replace, while commented out code is harder to maintain. Consider for instance the case of modifying a function where you want to add a parameter. With code, you'd have to fix it the best you can, while you wouldn't with a simple reference to that function in the comment. -- Joel