From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-114726-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5852 invoked by alias); 31 Jul 2014 19:30:59 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 5841 invoked by uid 89); 31 Jul 2014 19:30:59 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 31 Jul 2014 19:30:58 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6VJUtbE010576	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);	Thu, 31 Jul 2014 15:30:56 -0400
Received: from host2.jankratochvil.net (ovpn-116-29.ams2.redhat.com [10.36.116.29])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6VJUoc6027145	(version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO);	Thu, 31 Jul 2014 15:30:53 -0400
Date: Thu, 31 Jul 2014 19:46:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Delete struct inferior_suspend_state
Message-ID: <20140731193050.GA7927@host2.jankratochvil.net>
References: <yjt2silh73aa.fsf@ruffy.mtv.corp.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <yjt2silh73aa.fsf@ruffy.mtv.corp.google.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-IsSubscribed: yes
X-SW-Source: 2014-07/txt/msg00831.txt.bz2

Hi,

I do not mind any way.

But in the case it is deleted I believe it is better to keep there at least
comments at the places where is currently #if 0.  So if one is adding a new
field one immediately knows where it should belong - to the 4 cases of 2x2
matrix {thread,inferior}_{suspend,control}_state - in the case it would belong
to the inferior+suspend combination.


Jan