From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8303 invoked by alias); 30 Jul 2014 08:21:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8256 invoked by uid 89); 30 Jul 2014 08:21:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 30 Jul 2014 08:21:49 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6U8LlR9029332 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 30 Jul 2014 04:21:47 -0400 Received: from blade.nx (ovpn-116-90.ams2.redhat.com [10.36.116.90]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6U8Ll6O012212 for ; Wed, 30 Jul 2014 04:21:47 -0400 Received: by blade.nx (Postfix, from userid 1000) id 6F68F2640C9; Wed, 30 Jul 2014 09:21:46 +0100 (BST) Date: Wed, 30 Jul 2014 08:29:00 -0000 From: Gary Benson To: gdb-patches@sourceware.org Subject: Re: [PATCH 10/13] Move ptid.h to common-defs.h Message-ID: <20140730082146.GA16393@blade.nx> References: <1406644635-1011-1-git-send-email-gbenson@redhat.com> <1406644635-1011-11-git-send-email-gbenson@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1406644635-1011-11-git-send-email-gbenson@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00777.txt.bz2 Gary Benson wrote: > This commit moves the inclusion of ptid.h to common-defs.h and > removes all other inclusions. > > gdb/ > 2014-07-28 Gary Benson > > * common/common-defs.h: Include ptid.h. > * defs.h: Do not include ptid.h. > * common/ptid.c: Likewise. As per: Pedro Alves wrote [1]: > It's a simpler rule if all .c files include their corresponding > .h file. I've updated my tree to reinstate '#include "ptid.h"' in ptid.c. I won't post an updated patch. Please review this patch as though the ptid.c change was not there. Thanks, Gary -- [1] https://sourceware.org/ml/gdb-patches/2014-07/msg00745.html