From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27936 invoked by alias); 25 Jul 2014 12:14:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27879 invoked by uid 89); 25 Jul 2014 12:14:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 25 Jul 2014 12:14:07 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6PCE32e016203 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Jul 2014 08:14:04 -0400 Received: from blade.nx (ovpn-116-66.ams2.redhat.com [10.36.116.66]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6PCE2PK011488; Fri, 25 Jul 2014 08:14:03 -0400 Received: by blade.nx (Postfix, from userid 1000) id 4DAE52640C8; Fri, 25 Jul 2014 13:14:02 +0100 (BST) Date: Fri, 25 Jul 2014 13:34:00 -0000 From: Gary Benson To: Pedro Alves Cc: Doug Evans , gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 1/3 v4] Introduce common/errors.h Message-ID: <20140725121402.GA12063@blade.nx> References: <1406206287-6817-1-git-send-email-gbenson@redhat.com> <1406206287-6817-2-git-send-email-gbenson@redhat.com> <53D1053E.6030902@redhat.com> <21457.18385.59886.323894@ruffy.mtv.corp.google.com> <20140725083642.GA4812@blade.nx> <53D22F22.4030101@redhat.com> <20140725111653.GA6301@blade.nx> <53D2438C.8040009@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53D2438C.8040009@redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00670.txt.bz2 Pedro Alves wrote: > On 07/25/2014 12:16 PM, Gary Benson wrote: > > Pedro Alves wrote: > > > On 07/25/2014 09:36 AM, Gary Benson wrote: > > > > I'm working on this now. My plan is to have > > > > gdb/common/common-defs.h (which includes config.h and the > > > > correct gnulib config.h) and have defs.h and server.h include > > > > common-defs.h as the first line. By the end of that series > > > > most every file will include defs.h or server.h and no file > > > > will include config.h. > > > > > > I think you meant, that files in gdb will include defs.h, files > > > in gdbserver will include server.h, and files in the shared > > > directories will include common-defs.h as the first line. > > > > Yes, eventually. I plan to submit an initial series, in which > > common-defs.h only includes the two config.h files, and any files > > not including either defs.h or server.h as their first line will > > be fixed up. If that proves acceptable, I'll submit one or more > > further series to move the various includes currently common to > > defs.h and server.h into common-defs.h, and finally something to > > switch common/target/nat files over to common-defs.h. > > Sounds good to me. I've distilled this into the wiki: > > https://sourceware.org/gdb/wiki/Common#Header_files_in_common_code_.28defs.h_vs_server.h.2C_etc..29 > > Please do feel free to edit it / improve it. > > (obviously that can evolve if the plan is objected to and changes.) Perfect, thanks for documenting this. Cheers, Gary -- http://gbenson.net/