From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2948 invoked by alias); 16 Jul 2014 10:23:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2922 invoked by uid 89); 16 Jul 2014 10:23:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 16 Jul 2014 10:23:49 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6GANmBI003583 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 16 Jul 2014 06:23:48 -0400 Received: from blade.nx (ovpn-116-88.ams2.redhat.com [10.36.116.88]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6GANlxk013217; Wed, 16 Jul 2014 06:23:48 -0400 Received: by blade.nx (Postfix, from userid 1000) id DE7062640C7; Wed, 16 Jul 2014 11:23:46 +0100 (BST) Date: Wed, 16 Jul 2014 10:38:00 -0000 From: Gary Benson To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 12/15] Add target/symbol.h, update users Message-ID: <20140716102346.GC22380@blade.nx> References: <1404902255-11101-1-git-send-email-gbenson@redhat.com> <1404902255-11101-13-git-send-email-gbenson@redhat.com> <87bnsxdrtj.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87bnsxdrtj.fsf@fleche.redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00417.txt.bz2 Tom Tromey wrote: > >>>>> "Gary" == Gary Benson writes: > > Gary> +/* See target/symbol.h. */ > Gary> + > Gary> +int > Gary> +target_look_up_symbol (const char *name, CORE_ADDR *addr, void *data) > > I never wrote these docs either... I've done this: +struct objfile; + +/* Find a symbol that matches NAME. Limit the search to OBJFILE if + OBJFILE is non-NULL and the implementation supports limiting the + search to specific object files. If a match is found, store the + matching symbol's address in ADDR and return nonzero. Return zero + if no symbol matching NAME is found. Raise an exception if OBJFILE + is non-NULL and the implementation does not support limiting + searches to specific object files. */ + extern int target_look_up_symbol (const char *name, CORE_ADDR *addr, - void *data); + struct objfile *objfile); Note that I changed the final parameter to struct objfile *objfile and added a forward declaration which is never filled out in gdbserver and added an assertion that objfile == NULL in gdbserver. I don't know whether you will agree with this but I'll change it back if you prefer. Thanks, Gary -- http://gbenson.net/