From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28525 invoked by alias); 16 Jul 2014 08:53:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28513 invoked by uid 89); 16 Jul 2014 08:53:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 16 Jul 2014 08:52:59 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6G8qvAv029986 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 16 Jul 2014 04:52:57 -0400 Received: from blade.nx (ovpn-116-88.ams2.redhat.com [10.36.116.88]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6G8qvr4011304; Wed, 16 Jul 2014 04:52:57 -0400 Received: by blade.nx (Postfix, from userid 1000) id 7FC4F2640C7; Wed, 16 Jul 2014 09:52:56 +0100 (BST) Date: Wed, 16 Jul 2014 08:55:00 -0000 From: Gary Benson To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 10/15] Add target/target.h Message-ID: <20140716085256.GA22380@blade.nx> References: <1404902255-11101-1-git-send-email-gbenson@redhat.com> <1404902255-11101-11-git-send-email-gbenson@redhat.com> <87fvi9drxk.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87fvi9drxk.fsf@fleche.redhat.com> X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00415.txt.bz2 Tom Tromey wrote: > >>>>> "Gary" == Gary Benson writes: > > Gary> This adds target/target.h. This file declares some functions > Gary> that the "common" code can use and that the clients must > Gary> implement. It also changes code in common to use these > Gary> functions. > > Gary> +/* See target/target.h. */ > Gary> + > Gary> +int > Gary> +target_write_memory (CORE_ADDR memaddr, const gdb_byte *myaddr, ssize_t len) > > These comments refer to docs I never got around to writing... : > > Gary> +extern int target_read_uint32 (CORE_ADDR memaddr, unsigned int *result); > Gary> + > Gary> +extern int target_write_memory (CORE_ADDR memaddr, const gdb_byte *myaddr, > Gary> + ssize_t len); How does this sound? /* Read LEN bytes of target memory at address MEMADDR, placing the results in GDB's memory at MYADDR. Return zero for success, nonzero if any error occurs. Implementations of this function may define and use their own error codes, but functions in the common, nat and target directories must treat the return code as opaque. No guarantee is made about the contents of the data at MYADDR if any error occurs. */ extern int target_read_memory (CORE_ADDR memaddr, gdb_byte *myaddr, ssize_t len); /* Read an unsigned 32-bit integer in the target's format from target memory at address MEMADDR, storing the result in GDB's format in GDB's memory at RESULT. Return zero for success, nonzero if any error occurs. Implementations of this function may define and use their own error codes, but functions in the common, nat and target directories must treat the return code as opaque. No guarantee is made about the contents of the data at RESULT if any error occurs. */ extern int target_read_uint32 (CORE_ADDR memaddr, unsigned int *result); /* Write LEN bytes from MYADDR to target memory at address MEMADDR. Return zero for success, nonzero if any error occurs. Implementations of this function may define and use their own error codes, but functions in the common, nat and target directories must treat the return code as opaque. No guarantee is made about the contents of the data at MEMADDR if any error occurs. */ extern int target_write_memory (CORE_ADDR memaddr, const gdb_byte *myaddr, ssize_t len); Thanks, Gary -- http://gbenson.net/