From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23811 invoked by alias); 15 Jul 2014 19:27:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23724 invoked by uid 89); 15 Jul 2014 19:27:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 15 Jul 2014 19:27:55 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6FJRrHp013337 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 15 Jul 2014 15:27:54 -0400 Received: from host2.jankratochvil.net (ovpn-116-54.ams2.redhat.com [10.36.116.54]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6FJRnOX018023 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Tue, 15 Jul 2014 15:27:51 -0400 Date: Tue, 15 Jul 2014 19:33:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: GDB Patches Subject: Re: [PATCH] Linux: Use kill_lwp/tkill instead of kill when killing a, process Message-ID: <20140715192749.GA32218@host2.jankratochvil.net> References: <53C54C7C.3070907@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <53C54C7C.3070907@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00404.txt.bz2 On Tue, 15 Jul 2014 17:45:00 +0200, Pedro Alves wrote: > Another thing I noticed by inspection while fixing the > recent gdbserver kill crash. > > Anyone know a reason we use plain "kill" here, instead > of tkill like everywhere else? I do not. Just it is the general GDB rule of "If it ain't broken, don't fix it". There are various old and patched kernels out there. Jan