From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14455 invoked by alias); 15 Jul 2014 17:03:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14320 invoked by uid 89); 15 Jul 2014 17:03:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 15 Jul 2014 17:03:10 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s6FH37FB003919 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Jul 2014 13:03:07 -0400 Received: from blade.nx (ovpn-116-92.ams2.redhat.com [10.36.116.92]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s6FGBnwj020906; Tue, 15 Jul 2014 12:11:50 -0400 Received: by blade.nx (Postfix, from userid 1000) id EA8EE2640C7; Tue, 15 Jul 2014 17:11:48 +0100 (BST) Date: Tue, 15 Jul 2014 17:17:00 -0000 From: Gary Benson To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 09/15] Mostly remove GDBSERVER from linux-waitpid.c Message-ID: <20140715161148.GA3214@blade.nx> References: <1404902255-11101-1-git-send-email-gbenson@redhat.com> <1404902255-11101-10-git-send-email-gbenson@redhat.com> <21444.10401.389963.415776@ruffy.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21444.10401.389963.415776@ruffy.mtv.corp.google.com> X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00400.txt.bz2 Doug Evans wrote: > Gary Benson writes: > > This commit mostly removes the use of GDBSERVER from > > nat/linux-waitpid.c. A use remains for some debugging > > code that I will remove when the Linux thread_db code > > is refactored. > > > > gdb/ > > 2014-07-09 Gary Benson > > > > * configure.ac [AC_CHECK_HEADERS] : New check. > > * configure: Regenerate. > > * config.in: Likewise. > > * nat/linux-waitpid.c: Don't include server.h or defs.h. > > (linux_debug) [debug_threads]: New declaration. > > gdb includes errno.h unconditionally, so the test is for some > gdbserver configs (right?). I think so. > It's going to be confusing to keep all the unconditional inclusions > of errno.h and yet seeing it tested for in configure.ac. It would > be good to document why things are the way they are. E.g., add a > comment to configure.ac or some such saying the test is needed by > common code used by gdb and gdbserver. > > OTOH, I see there is gnulib/import/errno.in.h. > Can we solve this with gnulib and thus make errno.h > unconditionally includable everywhere? I see gdb/gdbserver/linux-low.c includes errno.h unconditionally. I'm going to assume from that that linux-waitpid.c can do the same. I'll remove the conditionals from there and revert the configury changes. Thanks, Gary -- http://gbenson.net/