From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2430 invoked by alias); 15 Jul 2014 16:07:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2398 invoked by uid 89); 15 Jul 2014 16:07:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 15 Jul 2014 16:07:40 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C5483116268; Tue, 15 Jul 2014 12:07:38 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id L7piVByIhjdY; Tue, 15 Jul 2014 12:07:38 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 971BD11615E; Tue, 15 Jul 2014 12:07:38 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id B2F1540EBF; Tue, 15 Jul 2014 09:07:40 -0700 (PDT) Date: Tue, 15 Jul 2014 16:08:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 2/2] Only leave dprintf inserted if it is marked as persistent (PR breakpoints/17012) Message-ID: <20140715160740.GJ4888@adacore.com> References: <1404760664-17289-1-git-send-email-simon.marchi@ericsson.com> <1404760664-17289-2-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1404760664-17289-2-git-send-email-simon.marchi@ericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-07/txt/msg00397.txt.bz2 > 2014-07-07 Simon Marchi > > PR breakpoints/17012 > * breakpoint.c (remove_breakpoints_pid): Only skip removing > dprintf if it is marked as persistent. Pedro is really the maintainer who is the most familiar with breakpoint.c, I think, so it'd be better to wait for his feedback. But, with my patch champion hat on, I would suggest merging both patches into one, or else schedule the testsuite patch after the actual fix. It's a bit of a detail in this case, but generally speaking, we avoid having tests that fail until the fix is in. > --- > gdb/breakpoint.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c > index 908a1ea..fb833d0 100644 > --- a/gdb/breakpoint.c > +++ b/gdb/breakpoint.c > @@ -3112,7 +3112,7 @@ remove_breakpoints_pid (int pid) > if (bl->pspace != inf->pspace) > continue; > > - if (bl->owner->type == bp_dprintf) > + if (bl->owner->type == bp_dprintf && bl->target_info.persist == 1) > continue; > > if (bl->inserted) > -- > 2.0.0 -- Joel