From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17800 invoked by alias); 15 Jul 2014 15:42:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17771 invoked by uid 89); 15 Jul 2014 15:42:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 15 Jul 2014 15:42:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0984E116249; Tue, 15 Jul 2014 11:42:53 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qG+Gu5rMb6gX; Tue, 15 Jul 2014 11:42:52 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CF9C01161AD; Tue, 15 Jul 2014 11:42:52 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id E633B40EBF; Tue, 15 Jul 2014 08:42:54 -0700 (PDT) Date: Tue, 15 Jul 2014 15:44:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PUSHED] Handle OP_STRING in dump_subexp_body_standard Message-ID: <20140715154254.GH4888@adacore.com> References: <1405437917-1170-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1405437917-1170-1-git-send-email-simon.marchi@ericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-07/txt/msg00392.txt.bz2 > (gdb) set debug expression 1 > (gdb) print "hello" > ... (random garbage, possibly segfault) [...] > 2014-07-15 Simon Marchi > > * expprint.c (dump_subexp_body_standard): Handle OP_STRING. I forgot something! Do you think you could add a test for that? It should be fairly straightforward to add one, I think. -- Joel