From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4976 invoked by alias); 15 Jul 2014 10:01:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4965 invoked by uid 89); 15 Jul 2014 10:01:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: e06smtp10.uk.ibm.com Received: from e06smtp10.uk.ibm.com (HELO e06smtp10.uk.ibm.com) (195.75.94.106) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 15 Jul 2014 10:01:01 +0000 Received: from /spool/local by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 15 Jul 2014 11:00:57 +0100 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 15 Jul 2014 11:00:55 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4DBA72190045 for ; Tue, 15 Jul 2014 11:00:41 +0100 (BST) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s6FA0td830670982 for ; Tue, 15 Jul 2014 10:00:55 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s6FA0sqG008461 for ; Tue, 15 Jul 2014 04:00:54 -0600 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id s6FA0qeJ008359; Tue, 15 Jul 2014 04:00:52 -0600 Message-Id: <201407151000.s6FA0qeJ008359@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 15 Jul 2014 12:00:52 +0200 Subject: Re: [PATCH v2 11/13] TILEGX Linux: Fill 'collect_regset' in regset structure. To: arnez@linux.vnet.ibm.com (Andreas Arnez) Date: Tue, 15 Jul 2014 10:12:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, jiwang@tilera.com (Jiong Wang) In-Reply-To: <1403714949-28133-12-git-send-email-arnez@linux.vnet.ibm.com> from "Andreas Arnez" at Jun 25, 2014 06:49:07 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14071510-4966-0000-0000-000000BA37AB X-SW-Source: 2014-07/txt/msg00366.txt.bz2 Andreas Arnez wrote: > gdb/ > * tilegx-linux-tdep.c (tilegx_linux_supply_regset): Delete > function. Move logic to... > (tilegx_linux_regmap): ... this new register map. > (TILEGX_GREGS_SIZE): New enum value. > (tilegx_linux_regset): Refer to register map, replace supply > method by regcache_supply_regset, and add collect method. > +static const struct regcache_map_entry tilegx_linux_regmap[] = > + { > + { TILEGX_NUM_EASY_REGS, 0 }, Maybe TILEGX_R0_REGNUM instead of 0? > + { 1, TILEGX_PC_REGNUM }, This seems to get the register size wrong in 32-bit mode; note that TILEGX_PC_REGNUM has type builtin_func_ptr, which may be 4 bytes in size ... > + { 1, TILEGX_FAULTNUM_REGNUM }, > + { 0 } > + }; > > - if (regnum == gri || regnum == -1) > - regcache_raw_supply (regcache, gri, ptr); > - } > -} > +enum > +{ > + TILEGX_GREGS_SIZE = (TILEGX_NUM_EASY_REGS + 2) * tilegx_reg_size > +}; This doesn't appear to be used here. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com